From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-35750-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 28639 invoked by alias); 9 Jul 2015 13:25:45 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 35750
Received: (qmail 13064 invoked from network); 9 Jul 2015 13:25:43 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,
	RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=A6uVYryTqGTNP+r3VCDcrHprLd7GgqSRm+0RdFJL4uw=;
        b=IabOvjJXj1jElWH6WjfbJ50FkN2QND8VY8tVPYQD8kmy2Un8LZ4+zTdPR2d7qyu2On
         1aeEN2Owz8C4l4f3lA7xNEw1tEurckCQvP/+y3UHdtHgt70e92g5HkTGzMYI0Yq3PPBi
         x83wT/ph3J1Rf/NE4uXy9u6SKS5uIGOJDyxEBig/6vqINl5teoPWQiZrrmL3DNs1Z0xV
         bAc4no9T1ugl+SWujTUSI4jxSdqkEmq6/v49D2/cIRV5nWDsRUnq7qNn58KaVGuMwr5b
         p0c9SiZ9be9/G+I/cs6dRCQLG+0kC+fz1MhJfxjjj+jBtZ1yZQopW58gnoEW/kR38sUM
         HWLA==
MIME-Version: 1.0
X-Received: by 10.107.133.234 with SMTP id p103mr27682061ioi.85.1436448338368;
 Thu, 09 Jul 2015 06:25:38 -0700 (PDT)
In-Reply-To: <21764.1436444277@thecus.kiddle.eu>
References: <1436143012-9243-1-git-send-email-mikachu@gmail.com>
	<4740.1436181110@thecus.kiddle.eu>
	<97E3F4A3-6951-4848-8711-B8BD609BA79D@kba.biglobe.ne.jp>
	<CAHYJk3R267MFUk0qqh3ftQ_1U3=c0Ekqztk5_CCcqD5mttfo+w@mail.gmail.com>
	<21764.1436444277@thecus.kiddle.eu>
Date: Thu, 9 Jul 2015 15:25:38 +0200
Message-ID: <CAHYJk3S8V+6TxDq9ieZErJHd5trnR+iiYRoakUYgyPve-KvniA@mail.gmail.com>
Subject: Re: PATCH: _ps1234, _date_formats: Complete strftime formats for %D{}
From: Mikael Magnusson <mikachu@gmail.com>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Thu, Jul 9, 2015 at 2:17 PM, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> Mikael Magnusson wrote:
>>
>> I've also just noticed that completion after %D\{%\# and \^ doesn't
>> work, but single-quoted is fine.
>
> That's the fault of _ps1234.
>
> It's best to use compset -P and get to a point where _date_formats is
> called with $PREFIX only containing date formats and no prompt stuff.
>
> I finally worked out that the point of calling _default from _ps1234 is
> for print -P. That's _print's job to do that.

It was also so that nobody (weird?) would complain that PS1=/foo<tab>
stopped working, I think.

> +  compset -P '(\\|){' || pre=( -p "$bs{" )
> +  compset -S '(\\|)}*' || suf=( -S $bs\} )

Did you mean both $bs and \ here? You probably did, but doesn't hurt
to check :).

-- 
Mikael Magnusson