zsh-workers
 help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: Crash when exporting scalar without value and getsparam fails
Date: Sat, 10 Jan 2015 18:12:40 +0100	[thread overview]
Message-ID: <CAHYJk3S=J-xQrt52HgT96EnSBZP110n=ah3jXV+jEPdc5qaxtQ@mail.gmail.com> (raw)
In-Reply-To: <150110085722.ZM28022@torch.brasslantern.com>

On Sat, Jan 10, 2015 at 5:57 PM, Bart Schaefer
<schaefer@brasslantern.com> wrote:
> On Jan 10,  8:56am, Mikael Magnusson wrote:
> } Subject: Re: Crash when exporting scalar without value and getsparam fails
> }
> } On Sat, Jan 10, 2015 at 7:52 AM, Bart Schaefer
> } <schaefer@brasslantern.com> wrote:
> } > I think it should do nothing to the environment and return success.
> } >
> } > % bash -c 'unset IFS; export IFS; echo $?; printenv | grep IFS'
> } > 0
> } > %
> }
> } Ah yes, this is what happens for other parameters in zsh too.
>
> So did I somehow miss that this is specific to IFS and doesn't affect
> exports in general?  Or is there some other characteristic of the
> parameters that tickle this bug?

(I see that what I wrote is a bit unclear, but I'm not sure what the
'this' refers to, so I'll be specific about everything).
I don't know exactly how specific the crash is, but for most
parameters, doing an unset followed by an export does what you suggest
we should do for IFS. Eg, it isn't put into the environment, but upon
the next assignment it is set and exported into the environment
without another explicit 'export'. For IFS doing this just crashes
currently. The reason for which is that getsparam fails on IFS when it
is unset (I don't know why).

According to Oliver's original analysis, there may be other cases such
as dupstring failing (that would break everything else anyway), or
other unknown causes.

Neither of the changes I tested makes IFS behave as the generic case,
but both stop the crashing.

-- 
Mikael Magnusson


      reply	other threads:[~2015-01-10 17:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09 13:26 Mikael Magnusson
2015-01-10  6:52 ` Bart Schaefer
2015-01-10  7:56   ` Mikael Magnusson
2015-01-10  8:09     ` Mikael Magnusson
2015-01-10 17:25       ` Bart Schaefer
2015-01-10 18:28         ` Bart Schaefer
2015-01-10 19:10           ` Mikael Magnusson
2015-01-10 20:04             ` Bart Schaefer
2015-01-10 20:28               ` Mikael Magnusson
2015-01-10 16:57     ` Bart Schaefer
2015-01-10 17:12       ` Mikael Magnusson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHYJk3S=J-xQrt52HgT96EnSBZP110n=ah3jXV+jEPdc5qaxtQ@mail.gmail.com' \
    --to=mikachu@gmail.com \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).