From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: PATCH 2/2: [WIP] Efficient dedup for unsorted completions
Date: Wed, 30 Mar 2022 20:33:24 +0200 [thread overview]
Message-ID: <CAHYJk3SDpoe4_dThAV6Qo_gS3efCDv9xEsAiQE4H4RQ6i=yr2Q@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7Y7hP90uwSg5a0056cBkOQSXw07p5GAVZ6giPR1vVqn=A@mail.gmail.com>
On 3/30/22, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Fri, Mar 25, 2022 at 6:44 PM Mikael Magnusson <mikachu@gmail.com> wrote:
>>
>> This implements my idea for sorting a temporary array and then using
>> that for deduplication.
>
> Minor nit, but after this patch I get:
>
> compcore.c: In function ‘makearray’:
> compcore.c:3289:26: warning: unused variable ‘i’ [-Wunused-variable]
> 3289 | int dup, i, del = 0;
> | ^
i is actually used in this patch, but not in the fixed version where I
forgot to remove the declaration, thanks.
--
Mikael Magnusson
prev parent reply other threads:[~2022-03-30 18:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 11:56 PATCH: Fix inverted condition for unique completions Mikael Magnusson
2022-03-17 17:08 ` Mikael Magnusson
2022-03-17 19:17 ` Bart Schaefer
2022-03-17 19:32 ` Mikael Magnusson
2022-03-26 1:40 ` PATCH 1/2: Fix comments for UNIQCON/ALL Mikael Magnusson
2022-03-26 1:43 ` PATCH 2/2: [WIP] Efficient dedup for unsorted completions Mikael Magnusson
2022-03-29 16:07 ` PATCHv2 2/2: " Mikael Magnusson
2022-03-30 16:41 ` PATCH 2/2: [WIP] " Bart Schaefer
2022-03-30 18:33 ` Mikael Magnusson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHYJk3SDpoe4_dThAV6Qo_gS3efCDv9xEsAiQE4H4RQ6i=yr2Q@mail.gmail.com' \
--to=mikachu@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).