From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 30623 invoked from network); 30 Mar 2022 18:33:47 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 30 Mar 2022 18:33:47 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1648665227; b=n9uLvnWmX2KBmtywoDBRTThmVRoKcWm2viTLxwyjSfNuelakfRHKHSq/9+OMkWZqkHDeO55yNs mFnwEz7V52OVxJqhXCqxForo7mhjUNfylDGP0k5HhjVN4vdKQjkGAx6RvLOOH7fQrJcIB6EaeB 734houBScwu3i3Haejxi9GP4rvL9SYbvn7BJ7d1kmUTQLc0fxaXNYBXsB2pwcZXwNfjSAnOnxt Frc3tl0gAF22KXOurOpAk7UjyiyJNsMxVnNFDzFCvg0UQsc+mzM4Iy5twMs2YsCqlU6b02Gkhe eJ+xtP6iIFp6dtb8YjVuuk6RU5POkRWFedti4/AjyIGcPw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-pl1-f178.google.com) smtp.remote-ip=209.85.214.178; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1648665227; bh=GP7+WtpFaWlGDFaSvPoVn0PJfNuKKFwEdw1Si6ZzEi4=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:References:In-Reply-To:MIME-Version:DKIM-Signature: DKIM-Signature; b=BpyJ4O0Yp/k4sVOiWhb1j+JxYFyg3UxZn0AS833lJMRZEyYRbTtU6V2elVOnSDEaPnaW1Wc6ZF 3aoOxDUyXWMfEpWrQxsrfD69P3Z6tjgVDbjsOIPzggKDKNTi/JpZkmOeKrZqCOWlAkTbNgxf3O KCoRRXyRnQCZltx+dun6wq+fLU1v+8oS/TpkkXAgBpf1ypYN9sIxtkyOfoCBM50F1ofbSFI3Xq lGmn+CSegDkgH914Xe2qykFy7Bsr6ISLm6PWKu8qYws4gl99JNJ5pHRBetMhAaMpqAjQ5xf651 drnn19XMRYixLhfi9gp11SWIFvbk5b5yJroaNCttt/9zbQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:References:In-Reply-To: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=9N4lMx6jFCA7eDhrwlkDZ8C+wCNIRWC3el/K0qe2swQ=; b=YkrnJc5mCFNbR9/uTxMAaTuzmW P1EDmW6ZvY0DPlkhTnRnk09OU8jLnXr9useA1Q51Fp85OcY04R2tDJLqcSCVQ3btocXt+HMKLu5ol 9PN4IHZFV+nMnsUM3gZwXRbrZUcsgdWNeNw6ovsA0t/of0v5EXveoLgmSa/lPaEvzP88xhv84USqg t7Ui6I1mKVg9fHPEF3jmAx+SQO5OwZoDmLi4M4NjWqj5IxVfBjYphquWGHc4tynAFNB8ZRMKTdXUz Sv1e5EUjkuhYwvRpg3ZRt6+YyEZf1va5VFDiBge4m/iINF0YtWdwiOxTccgsdQrUReYVgkBlnejEB XmRGRm3A==; Received: from authenticated user by zero.zsh.org with local id 1nZd8c-0007un-4X; Wed, 30 Mar 2022 18:33:46 +0000 Authentication-Results: zsh.org; iprev=pass (mail-pl1-f178.google.com) smtp.remote-ip=209.85.214.178; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-pl1-f178.google.com ([209.85.214.178]:40942) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1nZd8I-0007aD-FO; Wed, 30 Mar 2022 18:33:26 +0000 Received: by mail-pl1-f178.google.com with SMTP id x2so21265519plm.7 for ; Wed, 30 Mar 2022 11:33:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9N4lMx6jFCA7eDhrwlkDZ8C+wCNIRWC3el/K0qe2swQ=; b=omtNW3YxFphkFcMbAIlrjX89N+92ndhhPHDqu3mIYrRi5FQEl7UhzF+Xte5VtgZnm9 toZinzBfJjLnpPZhNCw6JVZLVanQtt4IwAnVit06Yi8V2asqLVs6vqXnmdZ/C6FMYIKd CiiaRFuOGRYXHo7dhaRAFR1/1t64FaAHNwThWkk6pR2DQ4VEidhd5vqSMlakZ2jPjVmp 3mq6GZ3itrWipD7BrPeyutQvT2M22tdEfeS1dXoIS5JWYRojwuxnCmVXke2F7ySKMUvQ i8UK7TpzrhpRwnwanqz/XhQuuTFqcVtKSt9EqNkwr6mZJV81t6e2F6SeKFhuNwCcBC+g 6vdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9N4lMx6jFCA7eDhrwlkDZ8C+wCNIRWC3el/K0qe2swQ=; b=JPZqG5UQP13WoVar5qGiIlcKcB3wXbpCUHkDvtx1nPECCoj4vDz8+m7T9fP3692v3U EgMCao6R3OG1aUDc/mep0Cqe1gA7tP3Du5nZWVs8RkLHOYXnvpT1kN6boz51ekPUC1Dz UF34Ew66+Yht1drd3BxhwqILjvwjEIVI+WvAAGALMRxSCdBZmoSR0PgpslRG+xJNiSBA MWpahHs8GLmeCPpEFzmuQlBJ8jIfCZC8hjGp879FWcb9giGjwfmZxbbt8y2QB6ZhWgcX znsBT4Y22S7X94uPyTHGmFSJOapB4uy8TarcXgtrNyWqlbFlGllFOzk/f2PP1Rx5lqf9 +B4A== X-Gm-Message-State: AOAM532s04gux9r1jBkqudOqMs4tlZ8jlkqG5x7mLY2KjMz82PDmvwTX R1uiqTXr269bHBWGR8h2fWVFlWODYSRZYCftrthrd+Hv X-Google-Smtp-Source: ABdhPJzkYAmWyPfEcwua1Upr0m3K/YpgYAyEcmLA83OiQGk+h/A5F0S0gFFMaL0vDgkXc6y8G7Nh/g5OtSR1/0cK1Hk= X-Received: by 2002:a17:902:700b:b0:148:ee33:70fe with SMTP id y11-20020a170902700b00b00148ee3370femr1032570plk.38.1648665205105; Wed, 30 Mar 2022 11:33:25 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a05:6a10:fd0a:0:0:0:0 with HTTP; Wed, 30 Mar 2022 11:33:24 -0700 (PDT) In-Reply-To: References: <20220326014030.2802-1-mikachu@gmail.com> <20220326014330.3050-1-mikachu@gmail.com> From: Mikael Magnusson Date: Wed, 30 Mar 2022 20:33:24 +0200 Message-ID: Subject: Re: PATCH 2/2: [WIP] Efficient dedup for unsorted completions To: Bart Schaefer Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 49928 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On 3/30/22, Bart Schaefer wrote: > On Fri, Mar 25, 2022 at 6:44 PM Mikael Magnusson wrot= e: >> >> This implements my idea for sorting a temporary array and then using >> that for deduplication. > > Minor nit, but after this patch I get: > > compcore.c: In function =E2=80=98makearray=E2=80=99: > compcore.c:3289:26: warning: unused variable =E2=80=98i=E2=80=99 [-Wunuse= d-variable] > 3289 | int dup, i, del =3D 0; > | ^ i is actually used in this patch, but not in the fixed version where I forgot to remove the declaration, thanks. --=20 Mikael Magnusson