From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23878 invoked by alias); 7 Dec 2014 22:59:48 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 33922 Received: (qmail 2871 invoked from network); 7 Dec 2014 22:59:36 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=/hHxvol7wEzuTgGojuEq8eKR+fIU3Wk8YsD7neRBVKY=; b=0yebxeEy11l1NbgiuI3SUEtLT47PoEFO/hVutOTrG8pbkHZFSENIook7UfIDrtFMEf CGqsDzMqpYIps0IcxZPTMjwdujeB+jBnZDYbwVYffToVLrGx5nMno0R3YtMslBFHDeMO tnZs+34sO3gC1etNVti+WnIh6OpXIpe6w46/kJdkldWm2gbeEvFZnOLvM4qbJfnjK4Xt 8PkQwZZFCI+86NcgqkvhQDymL+GHRgA8vPMomxflf8wSZ4YiUdOgijYZwaJFBiPrR4M9 2dhJbPatP0kbPnxw35ZQajXrGg7lYa4+uMepUUgvKftUNNtRz9gv7PlsomRxtgaIGD+Q AiTg== MIME-Version: 1.0 X-Received: by 10.107.128.87 with SMTP id b84mr8306117iod.42.1417993172002; Sun, 07 Dec 2014 14:59:32 -0800 (PST) In-Reply-To: <20141207173944.2a77c0e7@pws-pc.ntlworld.com> References: <20141202155452.647182b4@pwslap01u.europe.root.pri> <141202084858.ZM31517@torch.brasslantern.com> <20141202172654.30e7d380@pwslap01u.europe.root.pri> <141204085606.ZM9146@torch.brasslantern.com> <20141204171226.301e9d2c@pwslap01u.europe.root.pri> <141205002023.ZM19736@torch.brasslantern.com> <20141205145054.655a2f70@pwslap01u.europe.root.pri> <141205100632.ZM508@torch.brasslantern.com> <20141205181330.2b458b46@pwslap01u.europe.root.pri> <20141205203417.2bc66b7b@pws-pc.ntlworld.com> <20141205220717.2f86bdd2@pws-pc.ntlworld.com> <20141207173944.2a77c0e7@pws-pc.ntlworld.com> Date: Sun, 7 Dec 2014 23:59:31 +0100 Message-ID: Subject: Re: Interrupting globs (Re: Something rotten in tar completion) From: Mikael Magnusson To: Peter Stephenson Cc: "Zsh Hackers' List" Content-Type: text/plain; charset=UTF-8 On Sun, Dec 7, 2014 at 6:39 PM, Peter Stephenson wrote: > On Sat, 6 Dec 2014 12:49:19 +0100 > Mikael Magnusson wrote: >> Another difference: the menu completion listing could previously be >> aborted with ctrl-c and keep the command line. It now closes the >> listing and aborts the command line. > > Here's a suggestion: when we go back to the main keymap, assume that if > the user typed ^C in the mean time they want to continue editing from > this point. I think that fixes this case. > > (This is only on the interrupt_abort branch, again.) > >> Additionally, with menu selection, you could previously ctrl-c out of >> selection and get to the menu, ctrl-c that again, and still have the >> command line. Now you just go straight from selection to a new empty >> command line. > > This second case was already working for me (interrupt_abort branch with > Sven-comment-restoration, commit e385312e0937). I tried both > MENU_COMPLETE and AUTO_COMPLETE behaviour. There may be another way in. > Does the patch below help with this, too? > > I'm intending to commit this and then stop patching to allow us to take > stock of what effects are now present on the interrupt_abort branch. So > feel free to re-report any bad features. Yeah, I just tried the branch as of 'fix typo' and both of my issues are gone. (I did notice if you restart menu selection after ctrl-c and then ctrl-c it again, and so on, it keeps selecting the next entry, but it always did that now that I check). I'm not sure if depending on menu completion and menu selection having a different keymap feels right, then again, it does work. (Haven't read rest of thread yet). -- Mikael Magnusson