From: Mikael Magnusson <mikachu@gmail.com>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: "Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: PATCH: fix command substitution parsing
Date: Sat, 10 Jan 2015 20:56:58 +0100 [thread overview]
Message-ID: <CAHYJk3SRhx_D3ENXNF4dgWLBAPP7PNhvFFx7cn==tGse2e9CyQ@mail.gmail.com> (raw)
In-Reply-To: <20150107164836.035546c4@pwslap01u.europe.root.pri>
On Wed, Jan 7, 2015 at 5:48 PM, Peter Stephenson
<p.stephenson@samsung.com> wrote:
> According to the test suite enhanced with a few appropriate tests, this
> fixes the problem where syntactically significant but irrelevant
> unmatched closing parentheses caused command substitution to abort
> early.
>
> I don't believe that either, so we'll need to tease out whatever
> oddities remain. I think it's basically good enough to push, and the
> problems will only emerge when I do, but I'll use it myself for a day or
> so first.
Daniel Hahler found the following and reported it on irc, bisected to
this commit,
% alias foo=bar
% f() $(foo)
% which f
f () {
$(foobar)
}
--
Mikael Magnusson
next prev parent reply other threads:[~2015-01-10 19:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 16:48 Peter Stephenson
2015-01-09 21:26 ` Peter Stephenson
2015-01-10 1:28 ` Bart Schaefer
2015-01-10 19:56 ` Mikael Magnusson [this message]
2015-01-10 20:25 ` Peter Stephenson
2015-01-11 19:02 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHYJk3SRhx_D3ENXNF4dgWLBAPP7PNhvFFx7cn==tGse2e9CyQ@mail.gmail.com' \
--to=mikachu@gmail.com \
--cc=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).