From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-34217-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 4984 invoked by alias); 10 Jan 2015 19:57:02 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 34217
Received: (qmail 25612 invoked from network); 10 Jan 2015 19:57:00 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham
	version=3.3.2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=e5dHxHqte27crD4px26ebHiJ0lNWKPc5SzH4z1S36AI=;
        b=Q9R1O75+Sw8isbkXjX1zO5YXXXpxuyz+y2QHNI8RGruB8FEcI6dEpLzaRo/foeP/dE
         R7B0i5jQ+y/Q3awKAjKRNc9UwJksFy9q2klPgjsYr37/b9B8Yu+PnSrGN9BSSqw/CuZH
         kTmw7RWU9yzd4xjOi/dOHoYCkZ6kypk50NBVYCCGYgsPM6B6MJsiyQ18VPHyKVb1BMuu
         oO0t2OMLGv4Ku53V7vCGFNTC4S6cJw+4Cdc58PNXU9kqFzCC7unxewV7Y31rQt8FfNFB
         gEAVVtCiCCP07kUlIuDSREvxB7A9EnByRXghgu3oLMWkLHa5biGxerOeBXWSjC8jHDBR
         ok3A==
MIME-Version: 1.0
X-Received: by 10.42.102.66 with SMTP id h2mr18336171ico.88.1420919818900;
 Sat, 10 Jan 2015 11:56:58 -0800 (PST)
In-Reply-To: <20150107164836.035546c4@pwslap01u.europe.root.pri>
References: <20150107164836.035546c4@pwslap01u.europe.root.pri>
Date: Sat, 10 Jan 2015 20:56:58 +0100
Message-ID: <CAHYJk3SRhx_D3ENXNF4dgWLBAPP7PNhvFFx7cn==tGse2e9CyQ@mail.gmail.com>
Subject: Re: PATCH: fix command substitution parsing
From: Mikael Magnusson <mikachu@gmail.com>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: "Zsh Hackers' List" <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Wed, Jan 7, 2015 at 5:48 PM, Peter Stephenson
<p.stephenson@samsung.com> wrote:
> According to the test suite enhanced with a few appropriate tests, this
> fixes the problem where syntactically significant but irrelevant
> unmatched closing parentheses caused command substitution to abort
> early.
>
> I don't believe that either, so we'll need to tease out whatever
> oddities remain.  I think it's basically good enough to push, and the
> problems will only emerge when I do, but I'll use it myself for a day or
> so first.

Daniel Hahler found the following and reported it on irc, bisected to
this commit,
% alias foo=bar
% f() $(foo)
% which f
f () {
    $(foobar)
}

-- 
Mikael Magnusson