From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 23042 invoked from network); 29 Mar 2022 16:12:00 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 29 Mar 2022 16:12:00 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1648570320; b=gjLycioc0QQ/6u7SSWUV9TK3PrCmmttDRmbdarlHQQ6xqqUoLgHVRpp1d9kw3zXFuLhlM5VVSa dSJVLiISMyjnABj1LR4TrMAjyVJVNi/uImofSFCb7cib/XPcc9v/g3IrRxYMZzCUOJY58QcvJu YDo/ZsNW+NO+YlEO2Iar7JnmSh4McMB+8I0JGlkHeEHe121d93ccP2kLXolyW0phIyx0HYNGGr WjQD+nH/r7RmI7qWEHNkOLbAZvGerT7PzI7jL32yOnsOPaLrR7JYIWEq5BWwQ04XDQa6AuLcA5 dTkT3rKU6Xy3NvxW6ZZPBLY/NGZcSV9lBkN86CpC7VWykQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-pl1-f176.google.com) smtp.remote-ip=209.85.214.176; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1648570320; bh=/KTGdxOX5GaHxMbtDFqWgYkurDKh0x7KrWAl54jqfss=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:To:Subject:Message-ID:Date:From:MIME-Version: DKIM-Signature:DKIM-Signature; b=IcvXn2iEfQPQrsmSFAfrrMUQC1ybMBlHnxWZnTuPsdilbcLou22te4h4rVWEWTlLPDv8pTwe1B qxFxV0Fxlx6lWT0pp716R/lmjCfGiC9DvJSd8D8l9m5oLsrxJ8N3bk+SrEe1ShDU7fbVmA3Y3J sirv9IpEO9MCet4IfxjGk+s2d7FNdoiM5PlZBcoPV0TZb3y9eJqxyO3D/weaxcy7yxtdOjyo0f SgaS2/8Q6vbx9/lYnxjT9tDoavyKk1vHmqPPEkooZBlON9ZEv+5Rr4yIkwfrBOtsTo+7j/9DFu U2rr7PlKJFj3VpU9wGd6R1qNLD4YVL4X09THIDuC/jzS1A==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:To:Subject:Message-ID: Date:From:MIME-Version:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References; bh=IYVEWcAUcLFJ3BCMSzAfHJAkm3tTRXJSI2xiG2XVqlo=; b=OsJJiKBJGuAUSnkKsbzx8uLWV/ WWQI3cnsxzA1PYPHz90V35cH2zbYYkcfZWP0hwZ3B1bDUbtdAEH4PAukhQO61ExX8NaTJkXGMt373 Ct+QkSlItdnJVA2SrZlhHRuPk+JmE58ulUyHmBVaKF3OXo3VSgaaY6CyPkjvfP84alaLF1Q61Rvha Fu5nHQv77UMR2qr/6BDKbjHFjKC6Nt0Zad9bKuOI3eIt447Mru3/bhc4vrwNtj1mHE/9Df+B426hD 77e+z8g/QzMbAZ32YZOqT51wHCn807SWDNdAA+l8AaNvTwqbzUNf0VdSMYL/0Wt78Sr4y4seyg8Tr B9xoH8YQ==; Received: from authenticated user by zero.zsh.org with local id 1nZERs-000FHI-8U; Tue, 29 Mar 2022 16:12:00 +0000 Authentication-Results: zsh.org; iprev=pass (mail-pl1-f176.google.com) smtp.remote-ip=209.85.214.176; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-pl1-f176.google.com ([209.85.214.176]:38629) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1nZERX-000EwJ-PC; Tue, 29 Mar 2022 16:11:40 +0000 Received: by mail-pl1-f176.google.com with SMTP id n18so18051068plg.5 for ; Tue, 29 Mar 2022 09:11:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=IYVEWcAUcLFJ3BCMSzAfHJAkm3tTRXJSI2xiG2XVqlo=; b=GJvwUtIImGolbHRI+z8MokAUMFcIiq9gr9G+EleqULXgGOailYJH/SPTTZLjEVtTUD xSyXm6JlXzSJk+mY9gRCuJYSewsv8NpuXHRFRrQq6AGgZj3Q1N6vmD7Q8vgh7uL+pUNW kdx74kGSGVAnTuH9Ir4W5iNOwpmbrp2BSd2rbVAyXfLTihk3Tmj8KmgGlutnV5E1Eh13 HZO8Sjlr1BvZEu5x14hhnmRRj/A/2Ho7e8zSZ8G48adPuopB8v7mHT5A3ynoL4E2fq/T Vc/bI1p5RaLfGMBwsyMSBhNdSuQII1LR9L0RbLc4lBpqGp6fOrq5jmq8eTW/cfRZVAoW rmMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=IYVEWcAUcLFJ3BCMSzAfHJAkm3tTRXJSI2xiG2XVqlo=; b=n7pVhXt+v2yPmH0vlJ4y/Ben+zUraNX0cPqA8feODiI61VXGkCeaosZTcrDR4AEwk+ FegcR7Oe85cVhuuWvDpM1Z6xlFpj4xio/s0nd/YilQy8zVp9zVPCjVWoXFvAr+1qtTKE E4JAP4jZeTgA3ipqUhg+v/I3p2XhvTQChJjQKzBnF0n0FpZTsIxcEfjg/IOxoHik9Zd8 a++LuycUFcxPIeVYtrNHaFklR0iMTjb0w9JZK0LvGqxDD4L67QGhD/v4ekULZaBDfKGr eBjJ/Yg6ov0vlXawLVkvUa84SxvfpYhb9gCNY/axPDtG9kxFGJ0cfy38cV+w3N4V/vNg nPEQ== X-Gm-Message-State: AOAM530Ni8sLgXDGtAMvT7YSOZ9TFYIIDKkwDtDDqGF4A55BfvelZWEr hfS18kAfu4rTeG8YNZWGiBMowAB1SSouG/QQ4l4durY/ X-Google-Smtp-Source: ABdhPJwvDEguGDMtwUbD//VRoysSTxrbK37hQqNm1WLLSHJDPQbIlYNogYPkUY/OfH/EIjr+jnXKJ2igDwPekGztYS4= X-Received: by 2002:a17:90a:bb0d:b0:1bd:3baf:c8b4 with SMTP id u13-20020a17090abb0d00b001bd3bafc8b4mr320325pjr.15.1648570298483; Tue, 29 Mar 2022 09:11:38 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a05:6a10:fd0a:0:0:0:0 with HTTP; Tue, 29 Mar 2022 09:11:38 -0700 (PDT) From: Mikael Magnusson Date: Tue, 29 Mar 2022 18:11:38 +0200 Message-ID: Subject: Re: PATCH: crash with weird completer To: Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 49916 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On 3/10/22, Mikael Magnusson wrote: > > diff --git a/Src/Zle/compresult.c b/Src/Zle/compresult.c > index 8b5955819a..0fed297b56 100644 > --- a/Src/Zle/compresult.c > +++ b/Src/Zle/compresult.c > @@ -612,9 +612,10 @@ instmatch(Cmatch m, int *scs) > int pcs = zlemetacs; > > l = 0; > - for (bp = brbeg, brpos = m->brpl, > - bradd = (m->pre ? strlen(m->pre) : 0); > - bp; bp = bp->next, brpos++) { > + bradd = (m->pre ? strlen(m->pre) : 0); > + for (bp = brbeg, brpos = m->brpl; > + bp && brpos; > + bp = bp->next, brpos++) { > zlemetacs = a + *brpos + bradd; > pcs = zlemetacs; > l = strlen(bp->str); I haven't noticed any extra problems as a result of using this patch, so I'm just resubmitting it without the RFC tag, lest anyone be surprised when I commit it later. -- Mikael Magnusson