From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9016 invoked by alias); 11 Jan 2016 15:26:27 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 37563 Received: (qmail 3567 invoked from network); 11 Jan 2016 15:26:26 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=jlYbmora5j5mYpAwXBjLLecl0TTTeICSozggg5RO9Uw=; b=W+jWYrKAdfCa3evvgATOsk39QzmINpbXv/rJ4OLRoi/NLaCKfj1G4JrzNEou8xi4H4 8S4Q/o8XV0Am5zLgklh+uK9FDQ1SY5zcA/k4c9IUjtcD2Q7gDQd+1dbYQKeNHAnVEXbr U3lGTUcZUSv+yjZarFSJLwGqEPkJ4Y3iDXfUkxqJ3gCtZt8sBEPymdxJAXOpxusWFjHa w0/z1JcUhZsdCcRhfk4p5LBLyBkil+htH9CTo3W5aUbO9PNPrJCrFLOdV0F9FMXZmx99 rLT4vpmJtra4v3zjQLWiKSd17if8tcp7mVWI1pNJq2D6srpW+KGzGbGxKvTweze/uoDq OSkQ== MIME-Version: 1.0 X-Received: by 10.140.100.141 with SMTP id s13mr158873760qge.25.1452525982912; Mon, 11 Jan 2016 07:26:22 -0800 (PST) In-Reply-To: <5692D87E.20304@googlemail.com> References: <1450245754-2760-1-git-send-email-mikachu@gmail.com> <20151219094913.GF2358@tarsus.local2> <5692D87E.20304@googlemail.com> Date: Mon, 11 Jan 2016 16:26:22 +0100 Message-ID: Subject: Re: PATCH: Add zle-line-pre-redraw hook for highlighting From: Mikael Magnusson To: m0viefreak Cc: Daniel Shahaf , Bart Schaefer , Zsh hackers list Content-Type: text/plain; charset=UTF-8 On Sun, Jan 10, 2016 at 11:17 PM, m0viefreak wrote: > > > On 19.12.2015 10:49, Daniel Shahaf wrote: >> Bart Schaefer wrote on Wed, Dec 16, 2015 at 00:05:01 -0800: >>> On Dec 15, 2015 10:27 PM, "Mikael Magnusson" wrote: >>>> I haven't received any complaints about 36650 from testers, so I'll go ahead >>>> and push this. >> >> Hooray! >> >> This should fix between 2 and 5 z-sy-h issues: >> https://github.com/zsh-users/zsh-syntax-highlighting/issues/245 > > One remaining issue with this approach is the fact that this new hook is > not triggered when a minibuffer such as isearch is active and BUFFER > changes. > > Is it possible to add support for that, too? > > I don't know the zle internals very well, and I couldn't figure out the > right spot to place a call to the hook without causing performance > issues due to multiple (useless) calls. You can probably add your redraw hook at the end of your zle-isearch-update and zle-isearch-exit hooks (not sure if both are needed). If you don't use them already, just point them directly at your redraw hook function. -- Mikael Magnusson