From: Mikael Magnusson <mikachu@gmail.com>
To: Peter Stephenson <Peter.Stephenson@csr.com>
Cc: zsh-workers@zsh.org
Subject: Re: PATCH: Fix some more missing locals for $match
Date: Wed, 2 May 2012 14:51:05 +0200 [thread overview]
Message-ID: <CAHYJk3SZWDpOKS6XRBrD4zGH7Unk9Y6Bh024utBE4U2-rU51aA@mail.gmail.com> (raw)
In-Reply-To: <20120502115650.6c519661@pwslap01u.europe.root.pri>
On 02/05/2012, Peter Stephenson <Peter.Stephenson@csr.com> wrote:
> On Wed, 2 May 2012 12:48:12 +0200
> Mikael Magnusson <mikachu@gmail.com> wrote:
>> +local -a match
>
> Ideally, these should always be
>
> local -a match mbegin mend
>
> because all three are set, even though the other two aren't used
> anything like as much.
Ah, forgot about those, will include in the commit. I guess I can as
well check that all places that local match also local those. And
tabcompletion just reminded me of MBEGIN/MATCH/MEND too, but that's
probably my rc.
--
Mikael Magnusson
next prev parent reply other threads:[~2012-05-02 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 10:35 PATCH: Add missing local -a match in promptinit Mikael Magnusson
2012-05-02 10:48 ` PATCH: Fix some more missing locals for $match Mikael Magnusson
2012-05-02 10:56 ` Peter Stephenson
2012-05-02 12:51 ` Mikael Magnusson [this message]
2012-05-02 14:25 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3SZWDpOKS6XRBrD4zGH7Unk9Y6Bh024utBE4U2-rU51aA@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=Peter.Stephenson@csr.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).