From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29760 invoked by alias); 9 Mar 2016 11:12:47 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 38118 Received: (qmail 29065 invoked from network); 9 Mar 2016 11:12:46 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=Ow6AaXtIisKm1iffb40vLoJmNcYRf1feIKvUmD4w2ts=; b=uFLhsGdR2I+OLovZhFpfa8+oE0onpsR7OFylAAlz3roERwvuYWaer7BwyfFoMh5v8p Sd9SZ0ZgNz/WOvkuEJcq/IMUD2AgAFp42C4Q+kJEI/l4aEn8wpSUJ1+b18vQHqKwIGLk Ba9mcULlZ7dodQ1W9wVSZ1tUYFVYtamRJl+JU8y5fwbHeNKgwqy6xJeIPppQFk0305ii 9JHLW3aSy9m5OYID84dEiuY92OVkl4U741/0WUfngyxUjUhB9ZrJizDSSdIVWm4ytNqr MMSjr6Cv5gqsKGTdqb1P11RTZy23Rcu53PgDPjjlS2RmfGcW3o5Kp8mmdc9wV0+Fty8/ zGjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=Ow6AaXtIisKm1iffb40vLoJmNcYRf1feIKvUmD4w2ts=; b=B2KIgJMO9NiLyOGIKNzMt7tGNSWLWgJyARROVmLhd0losb8eLH+goKvc6U/wSHmGID crms8Y461kGRLX30UuSzGvGuwV3HhLL1MxXq2w2W0CoF9OUDmwERNw4tVFAOd0fC/LSb toM1D11X47gAr3x3gyxdYZX4yTzJAjZqkTjzZk8JwXpsCChSO28UmwqkUegtFLFucjNH V2+vHooiM393zz045sawJsmbqpM/4LzJ1cCvv+J3QnIcWjNhpaig2I1l8VsYobLRbrZl oOLu0dRDRmc+haC9bLhIiQ27/r5DD3ys7LZ1JQP5U2UqhDc/Tr0G1EnW0DiADIDNPUZ+ ns0A== X-Gm-Message-State: AD7BkJKYp8Nzn81TN+UW8C9OpqgFeKdSS9Z03oKoD9HMdG97rB3nRXr/pAxhDt7CsHv3BuLY2gs9eR1B8RbANA== MIME-Version: 1.0 X-Received: by 10.55.19.96 with SMTP id d93mr42108085qkh.12.1457521961974; Wed, 09 Mar 2016 03:12:41 -0800 (PST) In-Reply-To: References: <20160226175937.GA22547@lorien.comfychair.org> <160226114511.ZM17604@torch.brasslantern.com> <8456.1456706752@thecus.kiddle.eu> <160306094154.ZM20831@torch.brasslantern.com> Date: Wed, 9 Mar 2016 12:12:41 +0100 Message-ID: Subject: Re: reverse-menu-complete re-starting completion on 5.2? From: Mikael Magnusson To: Bart Schaefer Cc: Zsh workers Content-Type: text/plain; charset=UTF-8 On Mon, Mar 7, 2016 at 3:05 AM, Mikael Magnusson wrote: > On Sun, Mar 6, 2016 at 6:41 PM, Bart Schaefer wrote: >> Meant to respond to this a while ago ... >> >> On Feb 29, 1:45am, Oliver Kiddle wrote: >> } >> } Even before that commit I can reproduce a variant of the problem by >> } starting menu completion with reverse-menu-complete and then switching >> } to a forwards menu complete. >> >> Not surprising, really. >> >> } [...] I'm really not sure why we need to be so >> } strict about the completion widget matching the last completion widget. >> >> The only reason I can think of is in case menu completion is invoked from >> within a user-defined widget, or otherwise entered by a different widget >> than simple forward/reverse menu completion. In that instance the user is >> presumably not continuing with the menu in progress but instead wants to >> start over. I.e. similar to tests of $LASTWIDGET in Functions/Zle/*. >> >> } anyone foresee any problem with just relaxing the condition (see patch). >> >> Maybe we'd need another flag action for "zle -f" to continue/interrupt a >> menu in progress, but probably it will work as expected more often with >> the patch than without. I suggest you push and we'll find out if a need >> for a flag arises. > > I can tell you I quite often complete a directory name using normal > completion, and then press ctrl-n to complete files inside by latest > modification date. If this continued cycling directories instead, it > would be quite inconvenient. But yeah, push and we'll see what happens > to that. Well, this use-case did indeed break with this commit. -- Mikael Magnusson