From: Mikael Magnusson <mikachu@gmail.com>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: sysopen (was Re: '>>' does not create file if set -C (noclobber) is active)
Date: Fri, 31 Jul 2015 16:02:20 +0200 [thread overview]
Message-ID: <CAHYJk3Sko_DE0g0w1jpok-2HDKAXxcm5i5535WArR2wbAbK=Dg@mail.gmail.com> (raw)
In-Reply-To: <31988.1438346493@thecus.kiddle.eu>
On Fri, Jul 31, 2015 at 2:41 PM, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> Mikael wrote:
>> Was there a reason the new commands were not made subcommands to
>> zsystem?
>
> sysread and syswrite are not zsystem subcommands.
>
> What is the purpose of zsystem (as opposed to a direct sysflock)? Is it
> that flock is not supported by some common systems?
Ah, I didn't actually notice that sysread and syswrite were already
there, and not added by your patch. I just saw zsystem after all the
others in the manpage and thought it seemed a bit inconsistent. It
would seem the only purpose is forward compatibility (eg, being able
to use zsystem supports from a script and have it work on older zshs
too).
> Coverity noticed that I'd made one part more complicated than it needs
> to be so this cleans that up (the !append was tautologous).
Aha, I submitted the new build and saw the warning but couldn't really
figure out what it was trying to tell me :).
--
Mikael Magnusson
next prev parent reply other threads:[~2015-07-31 14:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 1:02 '>>' does not create file if set -C (noclobber) is active Martijn Dekker
2015-06-25 1:49 ` Bart Schaefer
2015-06-25 2:22 ` Martijn Dekker
2015-06-25 7:30 ` Bart Schaefer
2015-06-25 14:04 ` Stephane Chazelas
2015-06-25 16:00 ` Bart Schaefer
2015-06-25 19:20 ` Chet Ramey
2015-06-26 14:14 ` Martijn Dekker
2015-06-26 20:15 ` Bart Schaefer
2015-06-27 1:54 ` Martijn Dekker
2015-06-27 3:38 ` Bart Schaefer
2015-06-27 17:02 ` Peter Stephenson
2015-06-28 0:02 ` Martijn Dekker
2015-06-28 0:46 ` Martijn Dekker
2015-06-28 7:48 ` Stephane Chazelas
2015-06-28 9:15 ` Oliver Kiddle
2015-06-28 14:00 ` Stephane Chazelas
2015-06-28 18:38 ` Bart Schaefer
2015-06-28 19:30 ` Stephane Chazelas
2015-07-23 2:56 ` PATCH: sysopen (was Re: '>>' does not create file if set -C (noclobber) is active) Oliver Kiddle
2015-07-24 10:57 ` Peter Stephenson
2015-07-24 11:55 ` Peter Stephenson
2015-07-30 11:05 ` Mikael Magnusson
2015-07-31 12:41 ` Oliver Kiddle
2015-07-31 14:02 ` Mikael Magnusson [this message]
2015-06-28 17:19 ` '>>' does not create file if set -C (noclobber) is active Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHYJk3Sko_DE0g0w1jpok-2HDKAXxcm5i5535WArR2wbAbK=Dg@mail.gmail.com' \
--to=mikachu@gmail.com \
--cc=okiddle@yahoo.co.uk \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).