zsh-workers
 help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: [PATCH] bracketed-paste: change quoting style
Date: Wed, 12 Aug 2015 03:08:04 +0200	[thread overview]
Message-ID: <CAHYJk3SowKgXQpse5eks36maNHp=SgBfjey=TyjopnBCZiTcvg@mail.gmail.com> (raw)
In-Reply-To: <20150811220922.GF1859@tarsus.local2>

On Wed, Aug 12, 2015 at 12:09 AM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> Make bracketed-paste use ''-quoting instead of \-quoting (when NUMERIC
> is nonzero).
>
> It's a bikeshed, of course, but I think '' is more readable.
>
> diff --git a/Src/Zle/zle_misc.c b/Src/Zle/zle_misc.c
> index 502e41e..5f2a580 100644
> --- a/Src/Zle/zle_misc.c
> +++ b/Src/Zle/zle_misc.c
> @@ -779,7 +779,7 @@ bracketedpaste(char **args)
>         int n;
>         ZLE_STRING_T wpaste;
>         wpaste = stringaszleline((zmult == 1) ? pbuf :
> -           quotestring(pbuf, NULL, QT_BACKSLASH), 0, &n, NULL, NULL);
> +           quotestring(pbuf, NULL, QT_SINGLE_OPTIONAL), 0, &n, NULL, NULL);
>         cuttext(wpaste, n, CUT_REPLACE);
>         if (!(zmod.flags & MOD_VIBUF)) {
>             kct = -1;

If we go here, we may as well allow the numeric to pick which quoting
style to use. :)

On a related note, someone on irc was confused about why
url-quote-magic stopped working in git, and it's of course because
bracketed pasting causes its self-insert hook to never run. We may
want to provide an alternative function to help with this case. (eg,
wrap bracketed-paste and quote if == http* or so.)

-- 
Mikael Magnusson


  reply	other threads:[~2015-08-12  1:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 22:09 Daniel Shahaf
2015-08-12  1:08 ` Mikael Magnusson [this message]
2015-08-12  2:52   ` Bart Schaefer
2015-08-12  3:13     ` Mikael Magnusson
2015-08-12  6:44       ` Bart Schaefer
2015-08-13 14:49 ` Oliver Kiddle
2015-08-13 16:20   ` Bart Schaefer
2015-08-13 23:19     ` Daniel Shahaf
2015-08-13 23:57       ` Bart Schaefer
2015-08-17 21:59         ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHYJk3SowKgXQpse5eks36maNHp=SgBfjey=TyjopnBCZiTcvg@mail.gmail.com' \
    --to=mikachu@gmail.com \
    --cc=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).