From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 3638 invoked from network); 30 Aug 2021 11:41:36 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 30 Aug 2021 11:41:36 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1630323696; b=DzGGguS1IvQhWLyGBRDU08TI1W4lxgsuaIN1ZkgU511DEtBXVXJBTnILQcaBlC+oKOy1hqil/M KHze1lNLymcESoISXixEYuRNsJdh1mJgdEdIbVh1N/hDKhHTT0LNo1At2pAeMYL5Z/XgfDfi/y 3ATzcGVWF0ogrH+Hx3/cOETqjfiCNetnur5Avr90KdLLKuajT4+UBQPtUo7JpngxwZN0V89S6A 1siucYc+48smR7PRKcv+ASogwov+ckxIVmlQzV0qURFk3eVJhIrTXYU7k3tQhr71OFIdG6Ea8T OeHVEwVZgJ423SLr5GG/UnE+Y2lcTNkmIW9WUjYMNzZFKA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ua1-f52.google.com) smtp.remote-ip=209.85.222.52; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1630323696; bh=0Pd46K0Me8oA+NoGrJBrqW6Xrbps7hM4t7Miq7+KoIg=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:References: In-Reply-To:MIME-Version:DKIM-Signature:DKIM-Signature; b=Tt2zHyKUbom/S56Tf1USIgWXN5y8QSFvTbkKRHtShz48xYcsiKVDJPuW7ZZDK8idjYHl8+dDEe pdaIjWCbaQIMKY2rpWHlH2z/MFxeVJtLwYXfUGQXssaUCvTew88AySWkN1JQFpFSTu8ERmHIIY QNwVcvlr2C4vaUG9v4Gvp3Yggft/I//3p0CHIOhoO98Y6g9t5/KJpLMPdAYw9453MbLi6pTcK8 2qMZoJthqeQ9K9Xs9Uvi+49UneUdT7YDcQ6okS1Kyxwb9IqG7nxorV0ABABcJGlQybKm0wqS99 mQgbU1hPOR5Sk2qHv1ishm1hznFeBs6bSGEulXAvxi+buA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:References:In-Reply-To:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=BOQ94LEbvrmsdGJ1dLh+PXhB2jh/eRTAM7gx4YhcabE=; b=XSOk7UGVYbVgoXJys+nSLUfhfE RtR/U5eH/VY5ezGKV2dGwp9Meq8JEwNcgtfcDFy+dTsgviX4iC+p7l4kx1a4G8ScquFtUzGqYcsF9 aw3NvDoAemUrD/CbkWXx3xDixdwyhiGFU1ZCvZv1anKuzuTEqs1WI1qnwjgHzm0rTUJpGqlCRcbhx CAL2a1xqjh9GKYDM4NVZxMgGDZ3llhk/lNsBjvustvS99dF0Ma2/hQ3E92cBVjg8TrZkWusdgodHW f51uHiyEnjUSDiqWfSNV9bbbRPV5OCLHMlpZYckU5lADrh6QgCgKWbgZ7eK1EXOijrkZl8I0Klu+d 8l7j5ooQ==; Received: from authenticated user by zero.zsh.org with local id 1mKffU-000Jqa-7T; Mon, 30 Aug 2021 11:41:36 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ua1-f52.google.com) smtp.remote-ip=209.85.222.52; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-ua1-f52.google.com ([209.85.222.52]:44910) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1mKffC-000JYD-Jm; Mon, 30 Aug 2021 11:41:19 +0000 Received: by mail-ua1-f52.google.com with SMTP id x6so7632356uai.11 for ; Mon, 30 Aug 2021 04:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=BOQ94LEbvrmsdGJ1dLh+PXhB2jh/eRTAM7gx4YhcabE=; b=mrjvBYWKoyjT3EOTG+4krELh3GnyOQllleOgXz7s0J4nIuUQnB8AjrFw+prRVBXmIW cRxsvEeoCGltvYpPdjZQ+26wQJZhuE5M4ntP+t8DSYWkIUgjLtetBlsQ4R47m1Fm0niU MVMej+dqrQK/Wi/PcIVnRcGhOdubqlj/6Tc2oKDhm3UgGFKLPznCycE8v3uap4Y8FBlU kg6Ag7RguH5oAdRpWltrrwxQ3dGSlOqT3pi1VPE4UI/6FJESbUG/pWziywVaqejtXT0K Rin+BDI1HGEJNlsD29Rmf2TdHKAurlO3DB7PMitrzxw/8WNF6HRsV34veUEKuQakhboy xz1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=BOQ94LEbvrmsdGJ1dLh+PXhB2jh/eRTAM7gx4YhcabE=; b=B8VL48Q7qZBDWNMLIOcQF7dLIgIGn1zfAjhkN1P3zig3X5GBpHrehCWUeOeuc+kf/W uPuKZeD38LceQlLqwS1u1D+fGB6nkQuyaSnZs2EWEiBqkbOxAbJRbh7/bqyA9y35QItz /KbYy/kHUl+6lwYe15UjyBYtWW9zrSN5OP9WmAm6TTv1mIZ+1V5vZhX88gTuEDoiuzem xOlPLn83mLHTp4zjFOXuHNZopsvdakQSa2IEVcvW55jfz2HR1S9REw0w31w/+uqU+Mig HOqlPnK3FaS2f2x/nFlQjWKBYscylRmBHs/57E22h+aYoOsjbWoXGyoqpggNgryebvmv xKyg== X-Gm-Message-State: AOAM532vRDUGB9CCh53n4zSpPw5o2q3+KI94a43CDP+e6linUex7BP+R fzDSwT8b98td7vcgudMiWljwtKEgO48oQcU9Rog= X-Google-Smtp-Source: ABdhPJzmJmle1hhjQYkrQuRnd6CFhTLZKYNxydK28YqooZfGSoXJHAedP2ZcGfNS1DW9xkXxmKf8cal0iW5bYK2HPb4= X-Received: by 2002:a9f:31c8:: with SMTP id w8mr14269733uad.77.1630323677601; Mon, 30 Aug 2021 04:41:17 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ab0:60b2:0:0:0:0:0 with HTTP; Mon, 30 Aug 2021 04:41:17 -0700 (PDT) In-Reply-To: References: From: Mikael Magnusson Date: Mon, 30 Aug 2021 13:41:17 +0200 Message-ID: Subject: Re: [PATCH] Remove redundancies from `git` completion To: Marlon Richert Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 49331 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On 8/30/21, Marlon Richert wrote: > In _git-show, remove calls to __git_commits and __git_tags. > Rationale: 'commits' and 'tags' are already added by __git_trees. > Adding them twice makes `zstyle ... tag-order` give unexpected > results. > > In __git_recent_commits, remove the line that adds 'heads'. > Rationale: The completion for most subcommands already adds > 'heads-local' and 'heads-remote'. Adding an additional 'heads' inside > __git_recent_commits results in heads being listed twice in two > separate groups. > > > By the way: Why is there a `(( $+functions[_git-XXX] )) ||` statement > in front of each function inside Completion/Unix/Command/_git ? Can > those be removed? They are there so that you can override their implementation easily. -- Mikael Magnusson