From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id f558f7ec for ; Fri, 28 Jun 2019 00:20:46 +0000 (UTC) Received: (qmail 12934 invoked by alias); 28 Jun 2019 00:20:38 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44463 Received: (qmail 12440 invoked by uid 1010); 28 Jun 2019 00:20:38 -0000 X-Qmail-Scanner-Diagnostics: from mail-io1-f52.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25489. spamassassin: 3.4.2. Clear:RC:0(209.85.166.52):SA:0(-2.0/5.0):. Processed in 1.964059 secs); 28 Jun 2019 00:20:38 -0000 X-Envelope-From: mikachu@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.166.52 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=39WNjIS2JRQHkP2IBwk+bJRdQMEZZeB+qXbx7ll+5KY=; b=pL5dvdRKFGnqOdUSTVIUsPOU+al4o8wexlXu9HsU85E23PH9ajyhfef2yj1B0elG62 uHD9hTXqoQ7h6f0s0UcGVrrn7yIdKCacuhV5NBdEN2Nfe6onaNOBuZIjMEQNth1lGTnW 6v5WxxkoBYYRPXFBy3x7FsL6Qo4JlTsfXvmcGWfJ9X/1Yhih/2X25LwVGMcAcsi0YbZD J3JFBKKEnPqdiaKsuimPWg6wO9kI8yIwetCRIIk1aAvuumPoJBdpXA/irqehiTyWmHWx WlpIE5/vmVZObuOTtaUa6sVGN02MIG4j05rIs4Bad1j/ceJB6p60QatcxVnFvO+Xrkfg 9HAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=39WNjIS2JRQHkP2IBwk+bJRdQMEZZeB+qXbx7ll+5KY=; b=cYMDRyIcUuqdSpNOQZBGzQ9u6AA8qBlij14XHeZ19pW0NVG+jzEcoFgXi4rHUe2Lps tgmR/hUPzNikAy2XhgfSwI3CEuIPgEh0hxF0v7sqt4KTBdcqezjFHjDpDz0XTCPMaD4w PvORwzvtOQ/SCfce3Ivp4yiNGs9s2cm8qB3OdPftN2ADNIWDQQ6N1JEmeraziLBDaL6I /iqglYTpCyltgE5EIvgtzE6iabJP7wnjXCKL1DXqlAQN5AR1L6f8yuIhbwzHwg7TsIA3 v5ZfG2OHD5qcBuxpP6hwA9s11C77rxQoV75M4k99OL+UPJ7PPS8r7Ex8Qi4j9+GRJAlD l49g== X-Gm-Message-State: APjAAAW1gEr0CpS7pQ6PpjSXQ6jzPcEnImioEqu0kRcZHFX046Zwdzj9 JLwYZo9g6beTSYrvc8SRjKg0QDgV+pM+s9G12QhGxw== X-Google-Smtp-Source: APXvYqz+HM2BYkyDy3U+jorTHAg+SfLgnMja3YlgOsYCV/INV4JMXbYvdfYFlv8vNzt7K3ep81iFTwfRcJZd34GtLpA= X-Received: by 2002:a6b:641a:: with SMTP id t26mr7858927iog.3.1561681203762; Thu, 27 Jun 2019 17:20:03 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <797-1561676485.902916@C-Cf.WCnE.5Cn6> References: <20190626101908.548-1-kdudka@redhat.com> <797-1561676485.902916@C-Cf.WCnE.5Cn6> From: Mikael Magnusson Date: Fri, 28 Jun 2019 02:20:02 +0200 Message-ID: Subject: Re: [PATCH] {,un}applychange: do not call zle_setline(NULL) if quietgethist() fails To: Oliver Kiddle Cc: Kamil Dudka , zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" I can reproduce *a* crash, not necessarily *the* crash, by making a 2x2 window and then maximizing/unmaximizing the window. It seems to not reproduce if I have run any commands in the shell. On 6/28/19, Oliver Kiddle wrote: > Kamil Dudka wrote: >> There is a bug report in Red Hat Bugzilla about zsh crashing on NULL >> pointer dereference: https://bugzilla.redhat.com/1722703 >> >> I was not able to reproduce the crash myself but the attached patch >> should prevent zsh from crashing in this situation. > > It'd perhaps be good to add a DPUTS call here because while it is good > not to crash the condition does perhaps indicate a bug and it'd be > better not to hide it completely. I can't reproduce the crash either but > there must be some plugins or url quoting magic going on here. > More details of the setup used by the user might help find the > underlying problem. > > Oliver > -- Mikael Magnusson