From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 9133 invoked from network); 20 Jun 2021 21:09:14 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 20 Jun 2021 21:09:14 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1624223354; b=PvhwK9u/768Y9Tm0j9Q9vD7kHygxjXqyMvxvkf3Kp7JMeNCIG2BJnDtvuHqgRrlS0QOFUCcpSe pNXmiki0cs7Jew3QgyVLRv1ygoFPp1/7AcqQckz/MyzjEZ1/Y/Pd21E+s6nEBvuXtbWezINxYG IDQusCMmIrw06o1R/cSMpb/YnHrM0RRsi14argR+R/jc38Ez8ZOuoLyYXXodSElD+ehD9Gvq0f LN/WVlolqeWUdmHBAC8r0edlDB01ODiZMxEQzM42tjWjk93jfEw6oV8v6hG1tJqQLsQbRjhHtG 1/ahnRLI+AeNCsWBmt2z7VlxiHT6RZeVJtiyXOaS44pzkg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-il1-f180.google.com) smtp.remote-ip=209.85.166.180; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1624223354; bh=Qow7SFKjva/4SshZNKRt+Y+f3PDa8pqry0227WkKO0Q=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:References:In-Reply-To:MIME-Version:DKIM-Signature: DKIM-Signature; b=p5Wkpe4mLsRnFwzTS+74Zbrf89KxxuyRKX1C6HIXhvCGC1AZXAYSDYIOkkP1djZMA2CUBkMKqP 1V+EjyRX9g3ria+WL7mti9bDw/35yLSjIgj4CCKgDbfgGisYqFZKXaO3z2sDwx+rHTiVBdM8Ea hZTfAMgYFwrwf0oaFGodCaXqB/xIa3a2L9ypg8panwKhAkWm7Oh5pxV98V7OhqJS7H3xu1DiQV w9peJYwooO3+dOQ1zxhdWRxH9ETh+wXjMQI7nnklgssFdcdBAez84tVw4H7dkLp2ObpACam19Y EydrMkocTaWSIoYOwh4gmqw0gpTZaV4Uz+4a8kcXwt2CIg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:References:In-Reply-To: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=Qow7SFKjva/4SshZNKRt+Y+f3PDa8pqry0227WkKO0Q=; b=uOIQnr6vF8zvQskS4PbtKh9e2A sduGyuiqbehn2K5Y4u331IwkFuOQB3I7L+05+8VsM2m+ePs3rdXua++bEb+Ga4qkCoTdTCfXYXdrA K+H3mlGETUeAqlGwTSU3DMFAUAEpIM4ULLkCCF3DFFthydnb7pq7btODNP2Jl3aeFef/C9rIwHTwi EA57wQcMIq8MaHgf86Hb2Ktsw7mCOTN0GE/Pu86IaY5nTBRO7w1rOnGF0q7Rt5Lk14a1WQCSC4TpU GeymQ91gZH5/VDPxWVJz6nK3B8lgHL2CONMZhqPHoCE9PRnbTXqXhqqRbF2SxZsLFb5lt6/tY7OB2 ibyoahMA==; Received: from authenticated user by zero.zsh.org with local id 1lv4gn-00063u-3t; Sun, 20 Jun 2021 21:09:09 +0000 Authentication-Results: zsh.org; iprev=pass (mail-il1-f180.google.com) smtp.remote-ip=209.85.166.180; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-il1-f180.google.com ([209.85.166.180]:45679) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1lv4gE-0005lA-3v; Sun, 20 Jun 2021 21:08:35 +0000 Received: by mail-il1-f180.google.com with SMTP id b5so1489029ilc.12; Sun, 20 Jun 2021 14:08:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Qow7SFKjva/4SshZNKRt+Y+f3PDa8pqry0227WkKO0Q=; b=m39oeInWGmkzVDJHFa3cp8xAXo1eTKgN7RjR6qmaPOJToUEZg0p8LiTkdUiJGzUxMW taT8HDrmGfT7B1GP1szSmPhZcAsGoNgoAH3FA2PNrEIvVWVe/TiDa3C/0yJQTdNtuwmF UIXVRSz14PDsCP+8N7DgFSLn84RkFH3o0YOk3bUCfEsNK9eFbriz90CxxvQ34pscuGNv ouwufhMiyBI1psraYHdeyeFjacV88TohO5XircfkP7ls+tsmF3Zbr4CsKfhvheFjeJvW nFHMuT5xKcNgEaVXrtHDhjcxukLzWcHozoP3ghEGSEjF1F1etF/BpwBoEBpR657TSL5L a7WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Qow7SFKjva/4SshZNKRt+Y+f3PDa8pqry0227WkKO0Q=; b=iqeb1pe1NjBh75QcrRPE8jt1zj//+/tjB1zQrs9VTj6iS9mVn7q2VVSbSF4gBROU0Y 0Nsxtjn05uogX4ZZ3PrF0g/g06umBb9BBzxK8rBgurWsX0kqp+pCsr8c0DYkZJQdVAIc duYbnnOFvzFtIGl3ffAkZr2beicdumuYY7j1QISCGbNsK4hJSeouBjFp0R+FpFoIupIq v5S1eCMQQgqavxhFtGSDEItKbeBZkgKs9xxPPRqVPtu9Bus8jHbc+OhRdwrcZMB4Rt5B Nmj9LXLu167jZzjXARhDotQKRYwaypo5rtgVnNcHdsZYZIt2+A1DXamMt/eeom8qIsSK YE3g== X-Gm-Message-State: AOAM533UOImlCKHerrEAd+/3btKpmX+AvttenSkjwzbNmx2nvMXeReTK mYmxqdwzVktisSH6yruph246RCg3R0taGLqfQCJbICzR X-Google-Smtp-Source: ABdhPJyLlYgW40k+ZFVGtZ0C4sopxmG3dncWo27JV5gpfVFYqXj/SoKJnNjhs1znFMk1MOk1c4t877q9wmpgTyw6s6E= X-Received: by 2002:a05:6e02:1d1c:: with SMTP id i28mr15900468ila.13.1624223312713; Sun, 20 Jun 2021 14:08:32 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4f:2551:0:0:0:0:0 with HTTP; Sun, 20 Jun 2021 14:08:32 -0700 (PDT) In-Reply-To: References: <36227-1622676235.815398@zrY_.ZerV.zhJL> From: Mikael Magnusson Date: Sun, 20 Jun 2021 23:08:32 +0200 Message-ID: Subject: Re: [PATCH] Make _expand_alias more usable as a completer To: =?UTF-8?Q?Lawrence_Vel=C3=A1zquez?= Cc: zsh-workers@zsh.org, Marlon Richert Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 49098 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On 6/20/21, Lawrence Vel=C3=A1zquez wrote: > On Thu, Jun 3, 2021, at 5:42 PM, Marlon Richert wrote: >> On Thu, Jun 3, 2021 at 2:24 AM Oliver Kiddle wrote: >> > In practical tests, I'm not finding that this works too well, it ends >> > up >> > removing the characters typed. >> >> I cannot reproduce that. [...] Am I missing something? >> >> > I also wonder if this would be better done from within _command_names >> > directly but I'm not sure. >> >> Actually, I feel like it could instead be added to the _expand >> completer. Would that be a better idea than what I presented in this >> patch? > > Anyone have answers to Marlon's questions? If it helps, I disagree with conflating _expand_alias (expanding aliases) and _expand (filename expansion). --=20 Mikael Magnusson