Re: [PATCH] EXTENDED_HISTORY documentation typo

[Mikael Magnusson <mikachu@gmail.com>]

On 27 October 2011 17:57, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Oct 27,  3:51pm, Mikael Magnusson wrote:
> }
> } When I enable extendedhistory and run a command for a few seconds (in
> } the foreground), the <elapsed seconds> field is always 0.
>
> Hrm.
>
> torch% history -dD
>    1  08:09  0:00  setopt extendedhistory
>    2  08:12  0:30  sleep 30
> torch% SAVEHIST=50
> torch% fc -W /tmp/ehist
> torch% cat /tmp/ehist
> : 1319728176:0;setopt extendedhistory
> : 1319728336:30;sleep 30
> : 1319729722:0;history -dD
> : 1319729869:0;SAVEHIST=50
>
> (Timestamps are a bit far apart because I was distracted by phone call
> while doing this).
>
> Here's a thing ... if you're using a zshaddhistory hook to store lines
> to the history with "print -s" or "print -S", the start time of the
> command is lost and consequently so is the elapsed time; print forces
> the start and end times of the entry it writes to both be the time of
> the call to print.
>
> There may be a similar issue with HIST_IGNORE_ALL_DUPS in that the times
> for the oldest duplicate are kept, whereas HIST_EXPIRE_DUPS_FIRST keeps
> those of the most recent duplicate.

Ah, i have none of those set though, and i don't use a zshaddhistory
hook... This is a zsh -f session:

% cat /tmp/test
HISTFILE=/tmp/test
HISTSIZE=50
SAVEHIST=50
setopt incappendhist
setopt incappendhistory
cat /tmp/test
setopt extendedhistory
: 1319731616:0;cat /tmp/test
: 1319731618:0;sleep 5
: 1319731624:0;cat /tmp/test

% history -dD
    1  18:06  0:00  HISTFILE=/tmp/test
    2  18:06  0:00  HISTSIZE=50
    3  18:06  0:00  SAVEHIST=50
    4  18:06  0:00  setopt incappendhist
    5  18:06  0:00  setopt incappendhistory
    6  18:06  0:00  cat /tmp/test
    7  18:06  0:00  setopt extendedhistory
    8  18:06  0:00  cat /tmp/test
    9  18:06  0:05  sleep 5
   10  18:07  0:00  cat /tmp/test

At first i thought maybe it's one of my local patches, but i get the
same result on a remote host running 4.3.10.

-- 
Mikael Magnusson