zsh-workers
 help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: Step two seems to take us there
Date: Sat, 20 Jun 2015 19:11:14 +0200	[thread overview]
Message-ID: <CAHYJk3SvYcLOY5a+X0_y8VzbBHctruXG04iPkmkmCsGp=i7d-w@mail.gmail.com> (raw)
In-Reply-To: <20150620180335.04cc40c7@ntlworld.com>

On Sat, Jun 20, 2015 at 7:03 PM, Peter Stephenson
<p.w.stephenson@ntlworld.com> wrote:
> On Sat, 20 Jun 2015 04:48:08 +0200
> Mikael Magnusson <mikachu@gmail.com> wrote:
>> This change on top of the previous one seems to make things work when
>> the foo in ~[foo] has a / in it. I'm not sick enough to try and make a \]
>> in there work.
>>...
>> -  pre="${pre#*/}"
>> -  orig="${orig#*/}"
>> +  pre="${${pre#\~\[[^]]#]}#*/}"
>> +  orig="${${orig#\~\[[^]]#]}#*/}"
>>...
>
> You might want a backslash before the last "]".  (I think one works "to
> guide the eye" but isn't necessary before the one after the "^".)

That's probably a good idea, yeah. I noticed that I'm still getting
some "corrections: 1" with some completions, and I haven't been able
to figure out why yet. It happens even when my foo doesn't have a /
sometimes...

-- 
Mikael Magnusson


      reply	other threads:[~2015-06-20 17:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-07 10:32 _expand with dynamic named directories (and other issue) Mikael Magnusson
2015-06-18 11:28 ` PATCH: One small step towards making ~[foo]<tab> work Mikael Magnusson
2015-06-18 11:38   ` Mikael Magnusson
2015-06-20  2:48     ` PATCH: Step two seems to take us there Mikael Magnusson
2015-06-20 17:03       ` Peter Stephenson
2015-06-20 17:11         ` Mikael Magnusson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHYJk3SvYcLOY5a+X0_y8VzbBHctruXG04iPkmkmCsGp=i7d-w@mail.gmail.com' \
    --to=mikachu@gmail.com \
    --cc=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).