From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id f6f5b5c0 for ; Thu, 27 Feb 2020 18:47:08 +0000 (UTC) Received: (qmail 13074 invoked by alias); 27 Feb 2020 18:46:58 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45496 Received: (qmail 14921 invoked by uid 1010); 27 Feb 2020 18:46:58 -0000 X-Qmail-Scanner-Diagnostics: from mail-il1-f193.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25731. spamassassin: 3.4.2. Clear:RC:0(209.85.166.193):SA:0(-2.0/5.0):. Processed in 0.892531 secs); 27 Feb 2020 18:46:58 -0000 X-Envelope-From: mikachu@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.166.193 as permitted sender) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-transfer-encoding; bh=G6EMW+FAddVEid/EELx+Egaf0qqOsGRY5dQWy/qeJ/s=; b=pmtpj+3u/bdJggNjlntFG8SdBDe+lpa+1mDT05R7nCIDAtJyNsb8bEV125m2O0hR30 VcsJE1XLXQOQZG8QJUJkBf+xvYyLUtZfOoCmjQuji1btgnESNbDb6HoHaMbbS60eroaN PaY9vw8num4WfT1KnnIrfjWME2PXXNnahjHvFAmufuYTl9Tlg/ZXN/CeyAx6/J9V6Ery eqcS3Z8Ikw2ZXgqkYf7L/+t6uZwlGPy/l+YrNCH7wSItllCohZMokf1YD7qr/9uXon7F fttp/77A+cD2aw5O7lM7ldGocjnjjYGc3d5GPBR7S7LSmkdrpJM4Pw+mCiws+MrSjX1q pjgA== X-Gm-Message-State: APjAAAX8jsMrpqivm84FsDSp+wqtdOYTpMqrwHbYhZV0lrO9J2qmKsT1 ngx6DfOhkl9t9/e2Uu90jA8na4ts4yOBZ2913VMrqA== X-Google-Smtp-Source: APXvYqyASGisqFZHBMpjTi+KVn6efkbVbPjHTGQ6gct4JY3ifbfDoOhqAUKukWECG/yLLDuPXnMKaxIGcc/28AZE6JE= X-Received: by 2002:a92:4016:: with SMTP id n22mr710738ila.13.1582829183945; Thu, 27 Feb 2020 10:46:23 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20200227132229.3e290918@tarpaulin.shahaf.local2> References: <82F8CDE0-C95C-4D31-ABFC-EBB3C97799F3@kba.biglobe.ne.jp> <1B509B1C-A670-482F-9D88-2145E15D03A1@kba.biglobe.ne.jp> <20200109131553.hqetnd45sc43z6xb@tarpaulin.shahaf.local2> <087AE8B9-35B0-4258-9626-AACA85471A07@kba.biglobe.ne.jp> <20200111201549.GA1264@tarpaulin.shahaf.local2> <3340070A-53DD-40F0-8363-A8C7D84702D3@kba.biglobe.ne.jp> <374cecf6-45d5-4688-861f-cc52017dbcea@www.fastmail.com> <321F9465-ABF9-465D-9242-7EF9A0EDDBED@kba.biglobe.ne.jp> <20200227132229.3e290918@tarpaulin.shahaf.local2> From: Mikael Magnusson Date: Thu, 27 Feb 2020 19:46:22 +0100 Message-ID: Subject: Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin To: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On 2/27/20, Daniel Shahaf wrote: > Jun T wrote on Tue, 25 Feb 2020 18:38 +0900: > A couple of minor issues spotted in read-through: > >> --- a/Src/Builtins/rlimits.c >> +++ b/Src/Builtins/rlimits.c >> @@ -53,11 +40,214 @@ enum { >> +typedef struct { > > Suggest to name the struct type =E2=80=94 =C2=ABtypedef struct resinfo_t = { =E2=80=A6 } > resinfo_t=C2=BB =E2=80=94 as that tends to result in prettier output in t= he debugger. > >> +/* table of known resources */ >> +static resinfo_t known_resources[] =3D { It shouldn't be named anything_t at all, that suffix is reserved (see for example the system rlim_t type in the same file). Ref: https://www.gnu.org/software/libc/manual/html_node/Reserved-Names.html --=20 Mikael Magnusson