From: Mikael Magnusson <mikachu@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh-workers@zsh.org,
Cristiano De Michele <cristiano.demichele@uniroma1.it>
Subject: Re: _subversion is going to need to use 'help -v'
Date: Thu, 10 Oct 2019 18:29:15 +0200 [thread overview]
Message-ID: <CAHYJk3Szq6838NLionHrGiRpAi4H-Jc5i-JBepC1YFbQwrc=xw@mail.gmail.com> (raw)
In-Reply-To: <e65c9132-965b-4c18-aacc-e0f607f31b95@www.fastmail.com>
On 9/4/19, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> Daniel Shahaf wrote on Sat, 31 Aug 2019 20:19 +00:00:
>> tl;dr: A change made to Subversion (upstream) trunk today affects
>> _subversion.
>
> Patch attached. I think it's fairly safe to commit it already, even
> before the upstream release: it's unlikely that «svn help -v» will be
> made to mean "grow a toaster's arm".
The "Use 'svn help -v' to show global options" patch is broken:
re-compiling /usr/local/share/zsh/5.7.1-dev-0-mika/functions.zwc:
zrecompile:41: parse error near `fi'
the resulting code is:
if _cache_invalid svn-help-takes-verbose || ! _retrieve_cache
svn-help-takes-verbose; then
if [[ $(_call_program svn-help-v svn help help) == *--verbose* ]]
_svn_help_takes_verbose=$(( ! $? ))
_store_cache svn-help-takes-verbose _svn_help_takes_verbose
fi
which has both unclear indentation and intention. I would fix it but I
don't know if you meant to include both lines in the if. Please don't
use short_loops malformed syntax in distributed code because it always
leads to incorrectly written code like the above.
--
Mikael Magnusson
next prev parent reply other threads:[~2019-10-10 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 20:19 Daniel Shahaf
2019-09-04 2:54 ` Daniel Shahaf
2019-10-10 16:29 ` Mikael Magnusson [this message]
2019-10-10 16:58 ` [PATCH] _subversion: Fix syntax error in 44726/0001 Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHYJk3Szq6838NLionHrGiRpAi4H-Jc5i-JBepC1YFbQwrc=xw@mail.gmail.com' \
--to=mikachu@gmail.com \
--cc=cristiano.demichele@uniroma1.it \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).