From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id c86d9949 for ; Thu, 10 Oct 2019 16:30:02 +0000 (UTC) Received: (qmail 12597 invoked by alias); 10 Oct 2019 16:29:53 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44810 Received: (qmail 16095 invoked by uid 1010); 10 Oct 2019 16:29:53 -0000 X-Qmail-Scanner-Diagnostics: from mail-io1-f65.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25594. spamassassin: 3.4.2. Clear:RC:0(209.85.166.65):SA:0(-2.0/5.0):. Processed in 3.154113 secs); 10 Oct 2019 16:29:53 -0000 X-Envelope-From: mikachu@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.166.65 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=qAkQD4TUhtRRoFSB2J576KbZ/Od+fDGoDws9IE04l6A=; b=ZFM9xKEl0SX3mytDaAz1/1ul0KQ0M9faQ/OgHR3BTg9HSamr2In+cK9+IYkyWtyh0y xqJnW50WmEJnAhXRf1yG+cH7yWvQW5ppxePxKn0sYjOfj/+HHAN0tYQQHxijOrAYL61V l0tNYhnFyzN6jZBgK3RvejdS4+dCwhyYv/qTXJCKS723oG1SEBS37ZvEiTMSYOOR/HQe VuUYATOs1NiFKk2ljKMNkJwh7acXYEbwToryxppq9YXO8VlBB+rx846W9ZJhXXuE7Wek uvZ3DTL1IrHuTd2BC23R7P/A4nxUg1J1q53FHsQImaAizvrdLiDOj9yDj+3Dw7+gTKXL 2+Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qAkQD4TUhtRRoFSB2J576KbZ/Od+fDGoDws9IE04l6A=; b=W6MVX1OeYVpEYxftFcZSsfbOFzSDL3DrX9OJKEGYpGACYQxt/OWd/TURKOMujGVxBr yLGt+AiT/wTMKoo1c7WXkoxPF4+5/dLbFcyxpgN/VD3y2HvSAPyouvBPt/QoxMbCssUk rGmhI4djkTYtt15IWrcGrV9ShENxMkF/gKspkM4bJoiwxd3cW4jQ0fh8GE4TLdw3QMHL FMpK3tLYsbsze62NUergEtpctM3BjTeOJPPhpikj5yQWf1uQeCNmwCQheGDRpzN2LgKy +H6OlbAYmHYi+wl3uko7T/Hxjjnhq3eB25NKOztfwPFSNPtuDcc6RKOJkAY3vfUBmLD/ AOXQ== X-Gm-Message-State: APjAAAWqPs65mRCjaA6Lc9BhwsNeUBwbWg0O58yMgv6RMDKXQaIcl6fE BvGyYHhLuaqU6e62O+wAk57ovW5gTYTcJnXwgq4= X-Google-Smtp-Source: APXvYqy6UBY922ru4mk8cVF+fSBS5sW7Aac9tDF1BpyU4CyhkobEUm6+b04Bs7H4q67iKc8I37HKIsk2cnCGo4juwKM= X-Received: by 2002:a6b:d61a:: with SMTP id w26mr11127776ioa.159.1570724956212; Thu, 10 Oct 2019 09:29:16 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: From: Mikael Magnusson Date: Thu, 10 Oct 2019 18:29:15 +0200 Message-ID: Subject: Re: _subversion is going to need to use 'help -v' To: Daniel Shahaf Cc: zsh-workers@zsh.org, Cristiano De Michele Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On 9/4/19, Daniel Shahaf wrote: > Daniel Shahaf wrote on Sat, 31 Aug 2019 20:19 +00:00: >> tl;dr: A change made to Subversion (upstream) trunk today affects >> _subversion. > > Patch attached. I think it's fairly safe to commit it already, even > before the upstream release: it's unlikely that =C2=ABsvn help -v=C2=BB w= ill be > made to mean "grow a toaster's arm". The "Use 'svn help -v' to show global options" patch is broken: re-compiling /usr/local/share/zsh/5.7.1-dev-0-mika/functions.zwc: zrecompile:41: parse error near `fi' the resulting code is: if _cache_invalid svn-help-takes-verbose || ! _retrieve_cache svn-help-takes-verbose; then if [[ $(_call_program svn-help-v svn help help) =3D=3D *--verbose* ]] _svn_help_takes_verbose=3D$(( ! $? )) _store_cache svn-help-takes-verbose _svn_help_takes_verbose fi which has both unclear indentation and intention. I would fix it but I don't know if you meant to include both lines in the if. Please don't use short_loops malformed syntax in distributed code because it always leads to incorrectly written code like the above. --=20 Mikael Magnusson