From: Mikael Magnusson <mikachu@gmail.com>
To: Christian Hesse <list@eworm.de>
Cc: zsh workers <zsh-workers@zsh.org>, Christian Hesse <mail@eworm.de>
Subject: Re: [PATCH 1/1] add ssh option FingerprintHash
Date: Wed, 5 Aug 2015 23:37:00 +0200 [thread overview]
Message-ID: <CAHYJk3T1jmnksmQNYkcrNkKoJGq=vuK_DGwGpS05Oq73=jb00Q@mail.gmail.com> (raw)
In-Reply-To: <20150805225532.162afb82@leda.localdomain>
On Wed, Aug 5, 2015 at 10:55 PM, Christian Hesse <list@eworm.de> wrote:
> Mikael Magnusson <mikachu@gmail.com> on Wed, 2015/08/05 21:38:
>> On Wed, Aug 5, 2015 at 8:41 PM, Christian Hesse <list@eworm.de> wrote:
>> > From: Christian Hesse <mail@eworm.de>
>> >
>> > Signed-off-by: Christian Hesse <mail@eworm.de>
>> > ---
>> > Completion/Unix/Command/_ssh | 5 +++++
>> > 1 file changed, 5 insertions(+)
>> >
>> > diff --git a/Completion/Unix/Command/_ssh b/Completion/Unix/Command/_ssh
>> > index fb8fe57..b7b7e41 100644
>> > --- a/Completion/Unix/Command/_ssh
>> > +++ b/Completion/Unix/Command/_ssh
>> > @@ -219,6 +219,10 @@ _ssh () {
>> > _message -e 'escape character (or `none'\'')'
>> > ret=0
>> > ;;
>> > + (#i)fingerprinthash=*)
>> > + _values 'fingerprint hash algorithm' \
>> > + md5 ripemd160 sha1 sha256 sha384 sha512 && ret=0
>>
>> Not sure how I missed that one, thanks. My manpage only lists md5 and
>> sha256 as options, is it out of date?
>
> Oh, no... The same here. man ssh_config(5) from OpenSSH 6.9 lists md5 and
> sha256 only.
>
> I looked at the source code to find all possible algorithm. Not sure why...
> Probably because man ssh(1) lists the options, but no possible values.
>
> I've sent a patch to the openssh mailing list [0] to update ssh_config.5.
> Usually some time goes by until you get a response there... Until that
> happens - do we want to match documentation or code?
As long as they options work, we might as well complete them. Thanks
for double checking :).
--
Mikael Magnusson
prev parent reply other threads:[~2015-08-05 21:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 18:41 Christian Hesse
2015-08-05 19:38 ` Mikael Magnusson
2015-08-05 20:55 ` Christian Hesse
2015-08-05 21:37 ` Mikael Magnusson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHYJk3T1jmnksmQNYkcrNkKoJGq=vuK_DGwGpS05Oq73=jb00Q@mail.gmail.com' \
--to=mikachu@gmail.com \
--cc=list@eworm.de \
--cc=mail@eworm.de \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).