From: Mikael Magnusson <mikachu@gmail.com>
To: Peter Grayson <pete@jpgrayson.net>
Cc: Daniel Shahaf <d.s@daniel.shahaf.name>, zsh-workers@zsh.org
Subject: Re: [PATCH] Remove StGit patch detection from vcs_info
Date: Mon, 14 Nov 2022 06:17:02 +0100 [thread overview]
Message-ID: <CAHYJk3T8DGCFW5R=94QFsVx7QSxBqufu6_OcVeuOSwDi9o5Sag@mail.gmail.com> (raw)
In-Reply-To: <aaf82ac8-f7db-46e9-9995-d4a6dde1e5d9@app.fastmail.com>
On 11/14/22, Peter Grayson <pete@jpgrayson.net> wrote:
> On Sat, Nov 12, 2022, at 11:30 PM, Daniel Shahaf wrote:
>> Peter Grayson wrote on Sat, Nov 12, 2022 at 09:46:02 -0500:
>>> On Fri, Nov 11, 2022, at 6:49 AM, Daniel Shahaf wrote:
>>> > [re #2]: It sounds like StGit 2.x support can be implemented at the
>>> > cost
>>> > of one fork(2) for those who don't use StGit and under a microsecond
>>> > for
>>> > those who do. That doesn't sound like a deal breaker at all.
>>>
>>> Running `stg series` with StGit 2.0 takes about 12ms in my environment.
>>> StGit 1.5 it is about 32ms. Not a microsecond, but perhaps acceptable
>>> nonetheless.
>>>
>>
>> To be clear, are these figures the duration of the «stg series
>> --noprefix --applied» invocation?
>
> Yes.
>
>> What's the impact on people who don't have stg(1) installed, or who have
>> stg(1) installed but are currently in a worktree that doesn't use StGit?
>> I.e., are those figures immediately after `git init`, or in a worktree
>> that has a StGit patch stack, or?
>
> Without stg(1) installed, the cost would be however long it takes zsh to
> determine that the executable is not available in $path, which is
> ostensibly very fast (microseconds?).
>
> If stg(1) is installed, but run in a repo with a branch that has not been
> initialized with `stg init`, it's still about 12ms. Almost all that time
> is taken just to initialize a libgit2 Repository structure, which is
> used to interrogate the object database to determine whether a StGit
> stack is initialized.
fwiw, vcs_info lets you configure which vcs systems it looks for,
whether or not you have them installed. eg, I use:
zstyle ':vcs_info:*:*' enable git hg svn
although these days i could surely set that to just git...
--
Mikael Magnusson
next prev parent reply other threads:[~2022-11-14 5:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 20:43 [PATCH] Remove _stgit completion script Peter Grayson
2022-10-31 9:19 ` Daniel Shahaf
2022-10-31 10:13 ` StGit 2.0 and vcs_info (was: Re: [PATCH] Remove _stgit completion script) Daniel Shahaf
2022-11-01 3:00 ` [PATCH] Remove _stgit completion script Peter Grayson
2022-11-01 3:04 ` [PATCH] Remove StGit patch detection from vcs_info Peter Grayson
2022-11-11 11:49 ` Daniel Shahaf
2022-11-12 14:46 ` Peter Grayson
2022-11-12 15:42 ` [PATCH] Updated StGit patch detection in vcs_info Peter Grayson
2022-11-13 4:58 ` Daniel Shahaf
2022-11-16 20:45 ` [PATCH v2] " Peter Grayson
2022-12-08 14:52 ` [PATCH v3] " Peter Grayson
2022-12-08 22:06 ` Daniel Shahaf
2022-12-08 22:08 ` [PATCH] vcs_info git: Check the get-unapplied style as documented (was: [PATCH v3] Updated StGit patch detection in vcs_info) Daniel Shahaf
2022-12-09 0:59 ` [PATCH v3] Updated StGit patch detection in vcs_info Peter Grayson
2022-12-09 1:37 ` Daniel Shahaf
2022-12-10 12:55 ` Peter Grayson
2022-12-10 13:31 ` Daniel Shahaf
2022-11-13 4:30 ` [PATCH] Remove StGit patch detection from vcs_info Daniel Shahaf
2022-11-14 3:38 ` Peter Grayson
2022-11-14 5:17 ` Mikael Magnusson [this message]
2022-11-14 13:21 ` Daniel Shahaf
2022-11-14 13:15 ` Daniel Shahaf
2022-11-16 19:38 ` Peter Grayson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHYJk3T8DGCFW5R=94QFsVx7QSxBqufu6_OcVeuOSwDi9o5Sag@mail.gmail.com' \
--to=mikachu@gmail.com \
--cc=d.s@daniel.shahaf.name \
--cc=pete@jpgrayson.net \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).