From: Mikael Magnusson <mikachu@gmail.com>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: "Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: PATCH: parse from even deeper in hell
Date: Fri, 20 Feb 2015 04:22:30 +0100 [thread overview]
Message-ID: <CAHYJk3T9rJ1t7GJkRxgEO_q5JF_iFXkqKPwb-aSnZSEwhohD-A@mail.gmail.com> (raw)
In-Reply-To: <CAHYJk3RYztT7Urq08tysa-Cr0WgJf1Ehmrbingnbap=-eLWGdQ@mail.gmail.com>
On Fri, Feb 20, 2015 at 4:16 AM, Mikael Magnusson <mikachu@gmail.com> wrote:
> On Thu, Feb 19, 2015 at 11:03 PM, Peter Stephenson
> <p.w.stephenson@ntlworld.com> wrote:
>> On Thu, 19 Feb 2015 22:47:12 +0100
>> Mikael Magnusson <mikachu@gmail.com> wrote:
>>> I get a crapton of "bad(2) wordsplit reading history:" with this
>>> patch. It seems like all the failed lines have metafied characters in
>>> them, if that's a hint. Most don't contain any syntax characters at
>>> all, for example:
>>> hist.c:3499: bad(2) wordsplit reading history: mp3info 好きになり\M-c\M-^Aい.mp3
>>> at: 好きになり\M-c\M-^Aい.mp3s
>>> word: 好きになり\M-c\M-^Aい.mp3
>>
>> Unless I'm missing something, I don't think you've said what the real
>> characters you're expecting are. The broken ones aren't much use for
>> testing.
>>
>>> The (2) means it's the second of the two bad=1; assignments
>>> triggering.
>>
>> At line 3490?
>
> Yes.
>
>>> I'm also not sure why the utf8 is slightly mishandled in the output
>>> there. It has at least been unmetafied, the raw string in the history
>>> file is more or less:
>>> mp3info 好ぃ�になゃ�たぃ�.mp3
>>
>> So those aren't actually valid characters? Does that mean metafied
>> characters are getting into the history? I've made it necessary for two
>> more bytes to be metafied, so if the shell was expecting them to be
>> metafied in the history file they won't be. The bytes are 0x9e and
>> 0x9f. I guess we could special case those, but do we really output
>> metafied characters to the history file?
>
> The actual line in the history is
> mp3info 好きになりたい.mp3
> but in the history _file_, it's stored metafied, which is hard to
> paste into an email. I'm not sure why pasting the original string
> didn't occur to me. AFAIK, history files have always been metafied.
> I'm not sure why the た is mangled in the error message is what I tried
> to say originally. The final byte is 9f which I suppose is an esc with
> the 8th bit set. Maybe something is trying to double unmetafy? Running
> it through unmetafy() twice doesn't cause any problems though...
Just looked at the debug code and found out about ZSH_DEBUG_LOG, turns
out there's also a 0x8A just before the \M-c\M-^
--
Mikael Magnusson
next prev parent reply other threads:[~2015-02-20 3:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 10:13 Peter Stephenson
2015-02-19 21:47 ` Mikael Magnusson
2015-02-19 22:03 ` Peter Stephenson
2015-02-20 3:16 ` Mikael Magnusson
2015-02-20 3:22 ` Mikael Magnusson [this message]
2015-02-20 3:33 ` Mikael Magnusson
2015-02-20 3:43 ` Mikael Magnusson
2015-02-20 4:19 ` Ray Andrews
2015-02-20 9:54 ` Peter Stephenson
2015-02-20 10:00 ` Peter Stephenson
2015-02-20 10:12 ` Mikael Magnusson
2015-02-22 18:26 ` Peter Stephenson
2015-02-23 9:54 ` Peter Stephenson
2015-02-23 10:11 ` Peter Stephenson
2015-02-23 11:35 ` Mikael Magnusson
2015-02-23 12:36 ` Peter Stephenson
2015-02-23 12:57 ` Peter Stephenson
2015-02-23 13:38 ` Mikael Magnusson
2015-02-23 13:46 ` Mikael Magnusson
2015-02-23 13:51 ` PATCH: Remeta one frame earlier Mikael Magnusson
2015-02-23 13:58 ` Peter Stephenson
2015-02-23 14:05 ` Peter Stephenson
2015-02-23 14:32 ` Mikael Magnusson
2015-02-23 17:32 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3T9rJ1t7GJkRxgEO_q5JF_iFXkqKPwb-aSnZSEwhohD-A@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).