From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 68b42010 for ; Mon, 12 Nov 2018 13:38:47 +0000 (UTC) Received: (qmail 11583 invoked by alias); 12 Nov 2018 13:38:32 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43821 Received: (qmail 10872 invoked by uid 1010); 12 Nov 2018 13:38:32 -0000 X-Qmail-Scanner-Diagnostics: from mail-it1-f180.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.100.2/25112. spamassassin: 3.4.2. Clear:RC:0(209.85.166.180):SA:0(-2.0/5.0):. Processed in 1.873153 secs); 12 Nov 2018 13:38:32 -0000 X-Envelope-From: mikachu@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Rz1OVAHrZ67UxuVcVTyNu6+6Y8X7RZ0JnOPOyf/UTw4=; b=WXetYcvKJFjF5DLChviJuLABDFZK4Ea7Wz50LwehVoKfPGXtnmOdnbckSc2NJJg1iO LBh9F6X41txuSWhbsTKnCcZSR6dCcORHzs0kLpr2W/Bjo5Fd3M0Te/rZCNtoUJqAZ+Nt X8JEjrbCrvd6t8jxOQtY93it+KD8O6KmELO0Qt9n2aP5u78a3f/Ch1jeaPZRLVBQPXt4 vUWolCxYibHYIu5aJ4ZANhv+kDjV5fcQABmWEntZZe12qZkVE5CsmV996i4HSloYjTPz 50UAv2Pr11CdLN1FL2p9UXbBFPozwRr1NNzWqUcVmFkiiuiY9tAgbQFp0hIP5m09l8oV IzFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Rz1OVAHrZ67UxuVcVTyNu6+6Y8X7RZ0JnOPOyf/UTw4=; b=gHQ2TpEAafh2Jh95H6uoqdL+/rhF1V/JvtJhavIOD5XEBhh+6DVvbJzMV+s4uTbAAB Vw4nd0ukWkAlPcrRjvD0V7fpYeypJ89uMFa8txuDRWhuOaB9tEoCgtfsQri8GTj7oY1O ouo/2eTlI1zrRbhgZ3TCwLneDtKoLTVT2OqJmYCoW8iWmU2/JJqw6e/YwmoJ/5gSuPfH ED4FKka/CYur0On2Z5dAvTwYAkIBGhVNjayoknPzySFvhK0KUPVtAijsJM+1RIukWaax GUGetvty2JWlypuQwFbAw9f0V05PAgF4EPyAaq7ReA973CEy+NK3CD/4bRCCHIzscaW4 LqjQ== X-Gm-Message-State: AGRZ1gKfKGVCeCeXKQD+Eg/xo/eZ07SKNikFSbThoRbSdTRDGwvq60bU VrW4oWVSUMuk6+W1e4v91JkLoOoEVNIsgG1SC/s= X-Google-Smtp-Source: AJdET5cUSYOFVouDs2eTWINWgBtpT5zemWwqmIyr3N14AQzEAIXGJi3M9vIHjAQdNDDLFEykMa0N7BcYkxxdoAWCxnM= X-Received: by 2002:a24:4ecd:: with SMTP id r196-v6mr12615355ita.128.1542029907483; Mon, 12 Nov 2018 05:38:27 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <48216-1541900650.063823@-d-s.vJ6h.N9Zv> References: <48216-1541900650.063823@-d-s.vJ6h.N9Zv> From: Mikael Magnusson Date: Mon, 12 Nov 2018 14:38:26 +0100 Message-ID: Subject: Re: PATCH: allow multiple completion for gcc -Wsuggest-attribute To: Oliver Kiddle Cc: Zsh workers Content-Type: text/plain; charset="UTF-8" On 11/11/18, Oliver Kiddle wrote: > gcc allows the -Wsuggest-attribute option to be repeated because it can > be used with each of the four possible values. > > Oliver > > diff --git a/Completion/Unix/Command/_gcc b/Completion/Unix/Command/_gcc > index 8687adc6e..1052967c7 100644 > --- a/Completion/Unix/Command/_gcc > +++ b/Completion/Unix/Command/_gcc > @@ -628,7 +628,7 @@ args+=( > '-Wstrict-selector-match[Warn if type signatures of candidate methods do > not match exactly]' > '-Wstringop-overflow[Warn about buffer overflow in string manipulation > functions like memcpy and strcpy. Same as -Wstringop-overflow=]' > '-Wsubobject-linkage[Warn if a class type has a base or a field whose > type uses the anonymous namespace or depends on a type with no linkage]' > - '-Wsuggest-attribute=-[Warn about functions which might be candidates for > __attribute__((const))]:const:(pure const noreturn format)' > + '*-Wsuggest-attribute=-[warn about functions which might be candidates > for __attribute__((const))]:const:(pure const noreturn format)' > '-Wsuggest-final-methods[Warn about C++ virtual methods where adding > final keyword would improve code quality]' > '-Wsuggest-final-types[Warn about C++ polymorphic types where adding > final keyword would improve code quality]' > '-Wsuggest-override[Suggest that the override keyword be used when the > declaration of a virtual function overrides another]' Is there a specific reason you changed "Warn" to be lower case inconsistent with all the other descriptions here? -- Mikael Magnusson