From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: zsh got stuck without any message because of history lock file
Date: Thu, 26 Jun 2014 22:46:04 +0200 [thread overview]
Message-ID: <CAHYJk3TE+3UU0YHgANbz0af5kwMPrUPiSmO-MckbUvRKd232mQ@mail.gmail.com> (raw)
In-Reply-To: <140424220232.ZM11424@torch.brasslantern.com>
On 25 April 2014 07:02, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Apr 24, 10:02am, Bart Schaefer wrote:
> }
> } The way the code is currently written the shell will wait until 10
> } seconds after the modification time stamp of the file. If for some
> } reason the time stamp is wrong (clocks out of sync with NFS server,
> } for example) then it may end up waiting for longer.
>
> So ... here is a patch that checks for future timestamps. If it finds
> one, it leaves errno set to EEXIST, which results in:
>
> zsh: locking failed for /home/schaefer/.zhistory: file exists
>
> This isn't perfect, but at least it provides a clue.
>
> There's a controversial bit in this patch: It appears HIST_FCNTL_LOCK
> may have been broken ever since workers/28047 in 2010. That patch
> changed flockhistfile() [which is misnamed, it uses fcntl] to return 0
> on success, but then also this:
>
> ret = flockhistfile(fn, keep_trying);
> if (ret)
> return ret;
>
> That means that we only stop when flockhistfile() FAILS. On success,
> we go on and lock with BOTH fcntl AND a .LOCK file. This completely
> contradicts the documentation claim that "this may provide better
> performance." So the second hunk below makes flockhistfile() the
> only lock applied when HIST_FCNTL_LOCK is set.
>
> However, this would mean that every zsh that is accessing the same
> HISTFILE has to be using the same locking options. Is that OK?
I'm not 100% sure it's because of this change, but recently, I've had
new terminals stuck forever on startup until I exit all open terminals
logged in as that user (or possibly just a specific one of them). It
happens very spuriously, maybe a few times per week. I have
histfcntllock set. On one occasion I tried moving the .history file
instead of exiting, and this also immediately unstuck all new
terminals.
--
Mikael Magnusson
next prev parent reply other threads:[~2014-06-26 20:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 16:48 Andreas
2014-04-24 17:02 ` Bart Schaefer
2014-04-25 5:02 ` Bart Schaefer
2014-04-25 8:35 ` Peter Stephenson
2014-04-25 15:26 ` Bart Schaefer
2014-04-25 15:53 ` Bart Schaefer
2014-06-26 20:46 ` Mikael Magnusson [this message]
2014-09-06 9:03 ` Mikael Magnusson
2014-09-06 18:51 ` Bart Schaefer
2014-04-24 17:58 ` Andreas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3TE+3UU0YHgANbz0af5kwMPrUPiSmO-MckbUvRKd232mQ@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).