From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17550 invoked by alias); 12 Aug 2015 21:15:28 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 36140 Received: (qmail 11296 invoked from network); 12 Aug 2015 21:15:25 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=nntbuvUC+2BpbeBTnzKxdGsFSZCZF6dqvxKN2hlL3v8=; b=yR8gHvoKjMEjRH5rZOjyxrBVMRBz5Id/T97/G1SzO2PRDeE9fwnuRyz8BZU6/cCTOy O9V1oV4SyrGdg2yWrbgnUCAXuvjVgPXVNpUjdAP1j+he3eXs8Hj+gVtmHiz44PH6ZbgZ o3zfbOGAeVNwbQbkZwawVmqH0C2R3HzgG2VJ8oTvSKyEmz3eGv3JCmvn3VM/w2Ez/uZX vvUj1jOK49Ya/CE0XTZZcO6l7Ad++5FozvDt7fDDX/G9lpm/LG0nbMR3jxJewY/+B8EV FVqbPot4Rg1DIY/7+Yfe7cx873CNwMZeSER5kZp/DJ4/rny6IAHXOqymuC8ah4saUYQr f8mA== MIME-Version: 1.0 X-Received: by 10.50.33.37 with SMTP id o5mr19483803igi.3.1439414122444; Wed, 12 Aug 2015 14:15:22 -0700 (PDT) In-Reply-To: <150812135724.ZM14165@torch.brasslantern.com> References: <1439348703-8268-1-git-send-email-mikachu@gmail.com> <1439348703-8268-3-git-send-email-mikachu@gmail.com> <7518.1439400015@thecus.kiddle.eu> <150812115958.ZM14070@torch.brasslantern.com> <150812135724.ZM14165@torch.brasslantern.com> Date: Wed, 12 Aug 2015 23:15:22 +0200 Message-ID: Subject: Re: PATCH 3/5: _imagemagick: complete all files if image files didn't match From: Mikael Magnusson To: Bart Schaefer Cc: zsh workers Content-Type: text/plain; charset=UTF-8 On Wed, Aug 12, 2015 at 10:57 PM, Bart Schaefer wrote: > On Aug 12, 10:05pm, Mikael Magnusson wrote: > } Subject: Re: PATCH 3/5: _imagemagick: complete all files if image files di > } > } > pats=( " *(-/):directories:directories ${glob//:/\\:}:globbed-files" '*(-^/):other-files' ) > } > } I just went to send a new patch with this change, and noticed that the > } existing else case for */* does this (under list-dirs-first), > } > } elif [[ "$type" = */* ]] then > } pats=( '*(-/):directories ' '*:all-files ' ) > } > } should this not be other-files too? > > I've lost track of the significance of "$type" here. It's derived from > the argument to the -g option. Perhaps list-dirs-first is only meant > to apply to local directories, not to those found somewhere down the > tree? It's not documented that way, though. > > I think we'd have to try it and see whether it makes any difference. Well, I made the change locally and the tag in completions of files to rmdir changed from all-files to other-files. -- Mikael Magnusson