From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-30374-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 11392 invoked by alias); 24 Mar 2012 11:15:02 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 30374
Received: (qmail 14551 invoked from network); 24 Mar 2012 11:14:50 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED,
	DKIM_SIGNED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED,RCVD_IN_DNSWL_LOW,
	T_DKIM_INVALID autolearn=no version=3.3.2
Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.google.com designates 209.85.210.171 as permitted sender)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        bh=F7KqxhS5p+ftUx3eq4OmkjsEUNeMpfqdEdPRKocZXtk=;
        b=hDXEXHYG6Btd9p7GmZphOmMrHsRUhcXTBmU+EezII5fhtpXyU0P+cJZku6i4UA/qds
         BahXkZ8WoQ6sgvYGlfbujf8PMLbEZpHgplQOTaHNKTY5WdqSz9be5Wj/mWjyBd1TCNA6
         FRjlwpmrTgurYSQQzf1GG1dQ3Gy/OYggpvbNsVjJDjU9X9llB/6zb6NpnXmUlUHwgNPJ
         XL4kbfl501NHWby9gCNz77XESR+2j7uENKm9qujouy9rFFMTOwdl+V7lou9u5uLStUjC
         PUsQQ2ALu3mU9NG/fXGMARkPhBF7nwCpMNUFN5jMpFOxH13iwD4cahyTtYbSrWNQmND4
         Ysuw==
MIME-Version: 1.0
In-Reply-To: <CABZhJg__v4hN_9D+KCdwrBA0E06UB2C2w2grtdLw=c=zxkuhiw@mail.gmail.com>
References: <CABZhJg_V5objd2LHhvpGbukBsgNoau_2tTYcn+UOgWh3pAEmjg@mail.gmail.com>
	<CAHYJk3SbDQWZF2cNBhOzmqXeRLzNXFL05N-192kWuvy09HQG-g@mail.gmail.com>
	<CABZhJg__v4hN_9D+KCdwrBA0E06UB2C2w2grtdLw=c=zxkuhiw@mail.gmail.com>
Date: Sat, 24 Mar 2012 12:14:41 +0100
Message-ID: <CAHYJk3TL73yjCpJ7ArH81J9nN3r=TVCXknX9prtcaRrzAXA2og@mail.gmail.com>
Subject: Re: [PATCH] Add _gradle for gradle and gradlew completion.
From: Mikael Magnusson <mikachu@gmail.com>
To: =?UTF-8?Q?Jesper_Nyg=C3=A5rds?= <jesper.nygards@gmail.com>
Cc: zsh-workers@zsh.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 24 March 2012 11:55, Jesper Nyg=C3=A5rds <jesper.nygards@gmail.com> wrot=
e:
> 2012/3/24 Mikael Magnusson <mikachu@gmail.com>:
>> The patch seems (extensively) mangled, you can't post patches by
>> pasting them in the gmail web interface. You can either attach the
>> patch, or use git send-email.
>
> OK, I try again, with the patch attached.

You're defining a single function with the same name as the autoloaded
function, and then calling it, that serves no purpose so you can just
remove that indirection. (It's used in completers that want to define
extra helper functions). You could move the _gradle_caching_policy to
the toplevel and then this pattern would make sense. (There's no
namespaces for functions, so even though you define it inside _gradle
now, it stays around after _gradle returns.)

zstyle -T ":completion:*:*:$service:*" gradle-inspect || gradle_inspect=3Dn=
o
can probably be
zstyle -b ":completion:*:*:$service:*" gradle-inspect gradle_inspect
but I didn't test. :)

You need to quote the ? in -?,-h,--help. (The completion system sets
the nullglob option, so the whole argument just disappears without
errors).

Other than that it looks pretty good to me.

--=20
Mikael Magnusson