PATCH: complete more specific values for ssh key sizes

PATCH: complete more specific values for ssh key sizes

[Oliver Kiddle]

This adds specific values in the completion after ssh-keygen -b
depending on any key type that might have been specified. ecdsa keys
needing 521 and not 512 is an oddity it can be useful to have a reminder
of. I think any value will work with rsa but this adds the common
choices.

The mailing list software had got its database locked so this message
also serves as a test of that.

Oliver

diff --git a/Completion/Unix/Command/_ssh b/Completion/Unix/Command/_ssh
index 82a2a1827..af5ef48a0 100644
--- a/Completion/Unix/Command/_ssh
+++ b/Completion/Unix/Command/_ssh
@@ -5,7 +5,7 @@
 _ssh () {
   local curcontext="$curcontext" state line expl suf arg ret=1
   local args sigargs common common_transfer options algopt tmp p1 file cmn cmds sdesc tdesc
-  typeset -A opt_args
+  typeset -A opt_args tsizes
 
   common=(
     '(-6)-4[force ssh to use IPv4 addresses only]'
@@ -188,9 +188,14 @@ _ssh () {
     cmds=( -p -i -e -y -c -l -B -D -F -H -K -R -r -M -s -L -A -k -Q -Y ) # basic commands
     cmn=( -a -b -P -N -C -l -m -O -v -w -Z ) # options common to many basic commands (except -f which is common to most)
     cms=( -E -q -t -g -M -I -h -n -V -u -U ) # options specific to one basic command
+    tsizes=(
+      dsa 1024
+      ecdsa '256 384 521'
+      rsa '1024 2048 4096'
+    )
     _arguments -s $args \
-      "${p1}(${${(@)cmds:#-[pcKAO]}} ${${(@)cms:#-[t]}} -O)-a+[specify number of rounds]:rounds" \
-      "(${${(@)cmds:#-M}} -P ${${(@)cms:#-[MS]}})-b+[specify number of bits in key]:bits in key" \
+      "${p1}(${${(@)cmds:#-[pcKAO]}} ${${(@)cms:#-[t]}} -O)-a+[specify number of rounds]:rounds [16]" \
+      "(${${(@)cmds:#-M}} -P ${${(@)cms:#-[MS]}})-b+[specify number of bits in key]:bits in key [2048]:"'compadd ${expl\:/-X/-x} ${_comp_mesg\:=-} ${=tsizes[${opt_args[create--t]\:-rsa}]}' \
       "$p1(${${(@)cmds:#-[pc]}} -b $cms)-P+[provide old passphrase]:old passphrase" \
       "(${${(@)cmds:#-p}} -v ${${(@)cms:#-[qt]}})-N+[provide new passphrase]:new passphrase" \
       "(${${(@)cmds:#-c}} -v $cms)-C+[provide new comment]:new comment" \

Re: PATCH: complete more specific values for ssh key sizes

[Mikael Magnusson]

On 7/7/21, Oliver Kiddle <opk@zsh.org> wrote:
> This adds specific values in the completion after ssh-keygen -b
> depending on any key type that might have been specified. ecdsa keys
> needing 521 and not 512 is an oddity it can be useful to have a reminder
> of. I think any value will work with rsa but this adds the common
> choices.

I wonder if the 521 should even have a comment, to prevent helpful
fixes later (I had this problem trying to add "A bright coloured fish"
to the ID3 spec page on wikipedia :).

-- 
Mikael Magnusson