From: Mikael Magnusson <mikachu@gmail.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: Fix "35531: fallback on file completion"
Date: Fri, 18 Mar 2016 17:11:40 +0100 [thread overview]
Message-ID: <CAHYJk3TRoUzkidRXRU5yx2MS+946LpJr=QQfCKC+wq7kdaQX5w@mail.gmail.com> (raw)
In-Reply-To: <1458317336-27434-1-git-send-email-mikachu@gmail.com>
On Fri, Mar 18, 2016 at 5:08 PM, Mikael Magnusson <mikachu@gmail.com> wrote:
> The above commit just changed a bunch of stuff without testing, the
> result was that the completer didn't work. It now works, to an extent.
>
> The one remaining caveat is that if you enter a subcommand the completer
> doesn't recognize, it will go on to offer subcommands instead of falling
> back to _default. I'm not sure what it's trying to do with the
> "sanitize context" stuff, or "shift words" etc which just makes the rest
> of the code not know where it is, but I don't care enough to rewrite it.
> ---
> ChangeLog | 2 --
I apparently squashed my fixes into the revert commit a bit too
hastily as well :).
--
Mikael Magnusson
next prev parent reply other threads:[~2016-03-18 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 16:08 Mikael Magnusson
2016-03-18 16:11 ` Mikael Magnusson [this message]
2016-03-18 23:20 ` Oliver Kiddle
2016-03-19 1:13 ` Mikael Magnusson
2016-03-19 5:56 ` Oliver Kiddle
2016-03-19 12:36 ` PATCH: _adb: fix remote file completion + various fixes Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHYJk3TRoUzkidRXRU5yx2MS+946LpJr=QQfCKC+wq7kdaQX5w@mail.gmail.com' \
--to=mikachu@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).