From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: Completion of prefix redirections is -command- instead of -redirect-
Date: Thu, 27 Aug 2015 06:54:57 +0200 [thread overview]
Message-ID: <CAHYJk3TT8A1Lqu6gv0JRxxACwCOigYSsF+3CwBHNd_UdT8B5NQ@mail.gmail.com> (raw)
In-Reply-To: <150826214729.ZM12037@torch.brasslantern.com>
On Thu, Aug 27, 2015 at 6:47 AM, Bart Schaefer
<schaefer@brasslantern.com> wrote:
> On Aug 26, 9:35pm, Bart Schaefer wrote:
> }
> } Does this do it?
>
> To answer my own question, no, it doesn't ... or at least not entirely.
>
> Both WITH and WITHOUT the change in 36285, completing after this:
>
> % ls < ;
>
> completes files rather than commands. I suppose if you've botched the
> syntax you have no right to expect sanity, and the foregoing hasn't
> changed since 5.0.7, so we're no worse off.
Yeah, it's better than either with or without the 36285 patch, but
still doesn't handle all cases,
< <tab> gives files (correct)
; <tab> gives commands (correct)
< ; <tab> gives commands (correct)
foo < ; <tab> gives files (wrong-ish)
; < <tab> gives commands (wrong)
foo=bar; < <tab> gives commands (wrong, presumably same case as the above)
; < : <tab> gives commands (correct)
; < : : <tab> gives files (correct)
Is there any reason we can't just reset state to 'this is a new
command' when we see an unquoted solo semicolon? Or is determining
that this is the case in fact the trouble?
--
Mikael Magnusson
next prev parent reply other threads:[~2015-08-27 4:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 5:39 Daniel Shahaf
2015-08-26 18:18 ` Bart Schaefer
2015-08-27 0:16 ` Mikael Magnusson
2015-08-27 4:35 ` Bart Schaefer
2015-08-27 4:47 ` Bart Schaefer
2015-08-27 4:54 ` Mikael Magnusson [this message]
2015-08-27 5:14 ` Bart Schaefer
2015-08-27 6:22 ` Mikael Magnusson
2015-08-27 16:47 ` Bart Schaefer
2015-08-27 18:54 ` Mikael Magnusson
2015-08-27 19:00 ` Mikael Magnusson
2015-08-27 23:20 ` Bart Schaefer
2015-08-27 8:42 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3TT8A1Lqu6gv0JRxxACwCOigYSsF+3CwBHNd_UdT8B5NQ@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).