From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-38127-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 16988 invoked by alias); 10 Mar 2016 14:35:47 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 38127
Received: (qmail 15320 invoked from network); 10 Mar 2016 14:35:47 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc;
        bh=UCp1M2WWtDV+vad+T6L+GFlengtHIWXE/xTCG+aG3mk=;
        b=qwlexSZAGcToznfz4ZPiCUXNU7QRR4Lt32LApf36XjTLnNzF1SUeBsoXKAoosRDfsO
         bR1WdlqIh6px2div5FRdneqN6W6coKUO3tvh+iqS+sjsKr73CZQewJSIYkbu7y1YqPPg
         N1Kuce1Q36n5gJpjrlMTOCIOq81i81EJwrOsgujho4ek7dT5SMfYlEcOgXRvf/DRSyz0
         jSTE+ZHNKW449gO0iKIlG2QWxlbZwihfjHv1zG9RrSdyrSWOHwYxzDB+rRgloyhCTsE/
         qMSADWxmUQN2ILyvsft6XhaeoY7rGbS/sqWMa8dMc3BMb6q8eF/JhbTJNX3ga9iuzEla
         mMgw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:in-reply-to:references:date
         :message-id:subject:from:to:cc;
        bh=UCp1M2WWtDV+vad+T6L+GFlengtHIWXE/xTCG+aG3mk=;
        b=awjgWMmapXbipYe95AuFomTktYOKzh7PTIMr7ECgQ/mieNCVUq72kUJMctaYcCc0Wp
         bUBng2odbxFn+LU0PsKW8dMUXaQsLsoLh1UplOMCG9u0+mQ09q5kUTHDyJEoINtbR9ZW
         RfaS6D5bTkKK7AhPB11AuP5qoOhRlxvwDi0ApBUZVMy1Ta/dXBdKRCCSmOFxEnzv7zcr
         mPH68eZ7U2uEpJjiYmCxKlzhJd3buEv0lj1gUD1X+u1LWVBXFllJTM0t7lVTSDYhf9e0
         JPopZOgaKVsoN/vjvC7unvFQJQFDQ0TJVlCKTpsyMwqBR8rbhbCAXYlIWn4oSaECHTpx
         NWpw==
X-Gm-Message-State: AD7BkJI6yOIUGB18R/+K5Iy3yx1Zmhs2xORL+MWiJzDhUARfqz33OTepWuO8TYysOjo4kJ0RmGcbB3Z/udmQew==
MIME-Version: 1.0
X-Received: by 10.55.53.207 with SMTP id c198mr4528432qka.24.1457620541274;
 Thu, 10 Mar 2016 06:35:41 -0800 (PST)
In-Reply-To: <F614B9C0-B219-43E4-9A82-519F57D3DC84@kba.biglobe.ne.jp>
References: <20160309132444.GA2428@tarsus.local2>
	<F614B9C0-B219-43E4-9A82-519F57D3DC84@kba.biglobe.ne.jp>
Date: Thu, 10 Mar 2016 15:35:41 +0100
Message-ID: <CAHYJk3TTK1fUdZoPyJgHQMOov3tGkO5b8PtnB2snKox9WOf33g@mail.gmail.com>
Subject: Re: _git-reset doesn't complete newly staged files
From: Mikael Magnusson <mikachu@gmail.com>
To: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
Cc: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Thu, Mar 10, 2016 at 1:03 PM, Jun T. <takimoto-j@kba.biglobe.ne.jp> wrote:
>
>> Why does __git_ignore_line escape some characters with backslashes
>> before adding them to $ignored?
>
> I'm rather confused. Isn't it better to UN-quote them?
>
> % touch 'a b.txt'
> % git add <TAB>
> this completes a\ b.txt, and
> % git add a\ b.txt <TAB>
> this still completes a\ b.txt.
>
> Using
>     ignored+=(${(Q)line[1,CURRENT-1]})
>     ignored+=(${(Q)line[CURRENT+1,-1]})
> fixes this. Moreover,
>
> % git add *.txt <TAB>
> this does not complete a\ b.txt anymore.
>
> Or there are something I've overlooked.

Why does _git special case this at all, isn't the generic ignore-line
mechanism for the git-add context good enough?

-- 
Mikael Magnusson