From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-34158-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 25587 invoked by alias); 7 Jan 2015 08:27:07 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 34158
Received: (qmail 26846 invoked from network); 7 Jan 2015 08:26:53 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham
	version=3.3.2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=ft+Bhc9uiTLt4l/DqzXo4FuwtnvnYM3WKG778nhKMEg=;
        b=ceZRsJKIwnDK6yt0Qn0vjW2b4kd4Y/diCdIKQWfVBl9jFQ6NPcdCNpH/LOkzppPeaa
         iO5GJFZFcZS8Ol+UCdDGNFjzSQmTd4L/CbezGfCxCKm4MvW+/zjYxwsL4ZcSBoE2E/bv
         rtiShKk2odHkqnk235ySU1PL3DYcsF7rvbMk2XXLekaf/7lzAKTfi80M3KIwb04c+WQ8
         t67KK5sVFITG3ITKM6/O9662a1whBvQwJa9JBCQmU+gB3GZmxiBXexINFl/u+/EbZXbp
         5XQ/caGrCjGZvOUVmMT5Af8ToSylMIuAkY6BgzhNtQZRQtzHjz0BEf38CtJ4ypS+vAw2
         OxpQ==
MIME-Version: 1.0
X-Received: by 10.50.67.102 with SMTP id m6mr2474486igt.4.1420619212443; Wed,
 07 Jan 2015 00:26:52 -0800 (PST)
In-Reply-To: <150106231454.ZM26126@torch.brasslantern.com>
References: <1420590318-17047-1-git-send-email-mikachu@gmail.com>
	<150106223532.ZM1050@torch.brasslantern.com>
	<150106230807.ZM13656@torch.brasslantern.com>
	<150106231454.ZM26126@torch.brasslantern.com>
Date: Wed, 7 Jan 2015 09:26:52 +0100
Message-ID: <CAHYJk3TTRTnXG5HWcFOyzxADA=hm=juTwkrCGiKGH-XMRZdEzg@mail.gmail.com>
Subject: Re: PATCH (differently) Re: PATCH: Plug some fd leaks in bin_print
From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Wed, Jan 7, 2015 at 8:14 AM, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Jan 6, 11:08pm, Bart Schaefer wrote:
> }
> } Does coverity still find leaks after this?  What I've done is to move
> } option validity checking earlier in the function so that fout should
> } never get opened in the first place if we're not going to make proper
> } use of it later.

Only Clint and Oliver have admin access, so I can't actually upload
new code to coverity to check. Maybe if either of them see this they
could add me/us as admins too?

-- 
Mikael Magnusson