zsh-workers
 help / color / mirror / code / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] (final) unset "array[$anything]"
Date: Mon, 14 Jun 2021 11:04:23 +0200	[thread overview]
Message-ID: <CAHYJk3TW=P_qGbR7jCR+8FFS6A0GReP1+dNKG4ZKtwgWwNT6jQ@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7bNoRWUz6ZsUi9wZivfm1q8veD2d7Ld4jn_8qRJ+EmiBQ@mail.gmail.com>

On 6/14/21, Bart Schaefer <schaefer@brasslantern.com> wrote:
> Here's the diff just for "literal" unset, omitting all the
> alternatives and omitting the problematic hunk that modified getasg().
>
> I've included a NEWS entry, but have not yet attempted to create an
> incompatibilities section for README since it's not clear what the
> next zsh version number will be.

+that result as the exact hash element to unset.  This differs from previous
+versions of the shell, which would also remove a leading backslash for an
+unusual subset of characters in the expansion of $key.  Note this also
+means, for example, that
+  unset 'hash[ab]cd]'
+unsets the element with key "ab]cd" rather than silently doing nothing.

It is somewhat unclear (without using my contextual knowledge) if the
"Note this" applies to the old or the new behavior. Perhaps "Note
this" can be replaced explicitly with "Note that the new behaviour" or
so. (or "unsets" on the last line could become "now unsets".)

-- 
Mikael Magnusson


  reply	other threads:[~2021-06-14  9:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-13 22:56 Bart Schaefer
2021-06-14  9:04 ` Mikael Magnusson [this message]
2021-06-14 16:54   ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHYJk3TW=P_qGbR7jCR+8FFS6A0GReP1+dNKG4ZKtwgWwNT6jQ@mail.gmail.com' \
    --to=mikachu@gmail.com \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).