From: Mikael Magnusson <mikachu@gmail.com>
To: Ray Andrews <rayandrews@eastlink.ca>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: hist: remove wrong NULL terminator
Date: Fri, 9 Jan 2015 20:38:31 +0100 [thread overview]
Message-ID: <CAHYJk3TfLxqaHxPF6Vn+HNXzip8VbXLpsNo5Oyej8cVdFZteyw@mail.gmail.com> (raw)
In-Reply-To: <54B013C5.6090307@eastlink.ca>
On Fri, Jan 9, 2015 at 6:45 PM, Ray Andrews <rayandrews@eastlink.ca> wrote:
> On 01/09/2015 04:43 AM, Mikael Magnusson wrote:
>>
>> This actually writes a NULL to some arbitrary location in the caller
>> function's stack. Found by Coverity (Issue 1255746).
>>
>> The start of the quote() function does char **str = tr; and is called like
>> this,
>> quote(&sline);
>> sline in turn is just a char *sline;
>> The result of str[1] = NULL; is then, as far as I can tell, not anything
>> good. I also can't see any other thing that might have been intended to be
>> NULL-terminated here, so just remove it.
>
>
> Holy Cow. That's just been sitting there for god knows how long?
Yes, but it's actually pretty harmless, most other variables on the
stack in that function are never used if we enter this codepath.
--
Mikael Magnusson
next prev parent reply other threads:[~2015-01-09 19:38 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 12:43 Mikael Magnusson
2015-01-09 17:45 ` Ray Andrews
2015-01-09 18:33 ` Lawrence Velázquez
2015-01-09 18:36 ` Lawrence Velázquez
2015-01-09 19:38 ` Mikael Magnusson [this message]
2015-01-09 21:39 ` Ray Andrews
2015-01-09 22:30 ` Peter Stephenson
2015-01-09 23:39 ` Ray Andrews
2015-01-10 0:39 ` Bart Schaefer
2015-01-10 7:45 ` Ray Andrews
2015-01-10 22:04 ` Lawrence Velázquez
2015-01-10 22:50 ` Ray Andrews
2015-01-11 1:58 ` Bart Schaefer
2015-01-11 5:46 ` Ray Andrews
2015-01-11 7:10 ` Floating point modulus Bart Schaefer
2015-01-11 17:33 ` Peter Stephenson
2015-01-11 19:25 ` Bart Schaefer
2015-01-11 19:25 ` Ray Andrews
2015-01-11 20:00 ` Bart Schaefer
2015-01-11 20:58 ` Ray Andrews
2015-01-11 21:34 ` Peter Stephenson
2015-01-12 0:18 ` Ray Andrews
2015-01-12 10:03 ` Peter Stephenson
2015-01-11 19:36 ` Bart Schaefer
2015-01-11 20:01 ` Peter Stephenson
2015-01-11 20:04 ` Bart Schaefer
2015-01-11 20:25 ` Peter Stephenson
2015-01-12 0:02 ` Ray Andrews
2015-01-12 2:23 ` Bart Schaefer
2015-01-12 2:46 ` Bart Schaefer
2015-01-12 9:56 ` Peter Stephenson
2015-01-12 13:49 ` Peter Stephenson
2015-01-12 16:35 ` Bart Schaefer
2015-01-12 16:45 ` Peter Stephenson
2015-01-12 11:36 ` Vincent Lefevre
2015-01-10 7:08 ` PATCH: hist: remove wrong NULL terminator Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3TfLxqaHxPF6Vn+HNXzip8VbXLpsNo5Oyej8cVdFZteyw@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=rayandrews@eastlink.ca \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).