From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-34186-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 4237 invoked by alias); 9 Jan 2015 19:38:38 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 34186
Received: (qmail 21945 invoked from network); 9 Jan 2015 19:38:35 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham
	version=3.3.2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=qHy6/ynWErg661UtxQ4RMqTpT7LKI7gYzEH4IA/yDy4=;
        b=QW+PA9/0ENyY+j8iZelZPcm3ic44fdNdo5ueKkRq9uCV5uwEpFRUEQ2UFwgcZG4nEX
         emIKZAls4Cl7OjufaHOXxmTY6xnNoo0fp3YH1qrEfG6Ms2XtI1rdDpQq88Pdj/zPj39P
         gGBVbkzynGMhuC5Qx6Xwy/VMB8bUyCgvAPMHzEmD1OF2r7tsARr746agTHaPKueqqFXX
         cJEIpst6usCf6JPmD88Y4/szwDtUfOfTpEEYiPBeiPTs3nubn48Jc4aDDSjuRme9MAF2
         pHntzDmEd9F8jqFeplgo93JG1sdgFfdRRgS/VVsyJsZ8V/W84QvJ4aeLyC+gCiSwBRNW
         318g==
MIME-Version: 1.0
X-Received: by 10.42.38.9 with SMTP id a9mr14313279ice.68.1420832311110; Fri,
 09 Jan 2015 11:38:31 -0800 (PST)
In-Reply-To: <54B013C5.6090307@eastlink.ca>
References: <1420807419-9270-1-git-send-email-mikachu@gmail.com>
	<54B013C5.6090307@eastlink.ca>
Date: Fri, 9 Jan 2015 20:38:31 +0100
Message-ID: <CAHYJk3TfLxqaHxPF6Vn+HNXzip8VbXLpsNo5Oyej8cVdFZteyw@mail.gmail.com>
Subject: Re: PATCH: hist: remove wrong NULL terminator
From: Mikael Magnusson <mikachu@gmail.com>
To: Ray Andrews <rayandrews@eastlink.ca>
Cc: zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Fri, Jan 9, 2015 at 6:45 PM, Ray Andrews <rayandrews@eastlink.ca> wrote:
> On 01/09/2015 04:43 AM, Mikael Magnusson wrote:
>>
>> This actually writes a NULL to some arbitrary location in the caller
>> function's stack. Found by Coverity (Issue 1255746).
>>
>> The start of the quote() function does char **str = tr; and is called like
>> this,
>> quote(&sline);
>> sline in turn is just a char *sline;
>> The result of str[1] = NULL; is then, as far as I can tell, not anything
>> good. I also can't see any other thing that might have been intended to be
>> NULL-terminated here, so just remove it.
>
>
> Holy Cow.  That's just been sitting there for god knows how long?

Yes, but it's actually pretty harmless, most other variables on the
stack in that function are never used if we enter this codepath.

-- 
Mikael Magnusson