weird bit in _man

weird bit in _man

[Mikael Magnusson]

  if [[ $service == man ]] && (( $words[(I)-l] +
$words[(I)--local-file] )); then
    _files || return 0
  fi

surely that should be && ? Or maybe even _files; return since it
doesn't make sense to complete manpages at all if -l is given. But
returning success if no files were completed and not offering any
manpages doesn't seem all that useful... Am I missing something?

-- 
Mikael Magnusson

Re: weird bit in _man

[Oliver Kiddle]

Mikael Magnusson wrote:
>     _files || return 0

> surely that should be && ? Or maybe even _files; return since it

I suspect that it is a mistake. The original patch doesn't provide much
clue. && was probably intended but as you say ; is better because you
wouldn't want to go on to complete man pages.  It could perhaps specify
a glob much as _mere does (although allowing for .gz extensions).

The problem with that as a fix is that on some systems man has a -l option
that is something other than view a local file. Or at least, on Solaris,
it prints all the matching manual pages with their section numbers and
location. Perhaps we need to use _pick_variant but I notice that man is
completely different on Debian and on OEL (Oracle's Redhat clone) so it
may not be trivial.

Oliver