From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 24576 invoked from network); 25 Sep 2020 06:49:52 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 25 Sep 2020 06:49:52 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1601016592; b=QEAis1wna27clpDZeCx6zWugP7UEW2LilLXTxHj+LefS6GQnBT0fvNqVeO1oi5rTlL+oIty+20 xKpNYh9LsL77AE/94UrToDdhZtLrkcmqxSqyVA+/a4mJmPmHlstHmZvhBdo4GPUHO0to7SHZiP aTssaMKjaeC14t6y1hqkRGBrxEf1E+RaIXZNlWPZscgsUtqoWXbG+P5T1QB/52s71CmKNmuE+E pvWZT24XX7aG4inS5J2XpJm1yt943wU8XY04F2rpGh8LkKXSOrTherTl4KlqpVlDHqvyhWX7fj UgXQjdd+UuiM6cZSQw2tGBbMgCfcd4suxmv28ugWy2b62w==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-io1-f67.google.com) smtp.remote-ip=209.85.166.67; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1601016592; bh=/wNwSzP3KVEwHMsw0Mc06SUCKh4uNkWg93EtxYlTytg=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:References:In-Reply-To:MIME-Version:DKIM-Signature: DKIM-Signature; b=Wd3viaaO2DyKB+lNa72X9FUPxBee6avCQXydqjBLLji8PQsqyojGIc3UB0JeThNoznh3/dx7kz f5V+JtU90ClWEMqTPP682dO+EVC2Ija6S4fRfKORB5jU80ioF87OvmJVrntGluforo6j7EYrVh xNUuJrXJo+3vUR+oyE+ZgwlbVXjrsYgO5uDxh4Xrw1T7VPQex1p8bzfqddWBdxpODYpdBrjgsS XBWUgy/i9Y1ClHHwFbC7qXVA5RPRVRgnkHvMEv3emeTCEWI1TuLn4uj9KUVEYHy7cEF3RJrCX1 /tDbC6dwiSZaT98EyYP84kA5JWjPUhnQWOxt/sagkEyAZg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:References:In-Reply-To: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=y+IfnNmw1BqE1LY6Cb3DUFs6UpK8wCR2/RvwzHO9eyw=; b=xmtAIxYqPwtb7YiXtg3G36dKAS 1+uTgV7Nmfbfk3Ob46LM55yOl/xRRBCg8f92Mu4aJvkKbDbAijnJqHnhEHRnIoU+B6yXzuvCVPYx+ u7iMYp+jw3DnRO3vCrilV9azO6rgCrJlNgbCdHfjJ4kQdJf+8wHMnu5hVLiZ/tXH/3ht84G/+xotd jhHp1Hm/Y2TNViHaGLTKBqk4o2euv3VRb6kYX2uYTWOJhfWVDh205UlyNhpTr3umI/3ssBjkued9P oVcCpcy2WOYRq9Ok5prfNbBxL8y/FUS9FlKB7C+e1D/5Ttc5ny2eOzNSOIx9+3rA6698dcsOLc2yI X23zo3gg==; Received: from authenticated user by zero.zsh.org with local id 1kLhYF-000FtU-Mz; Fri, 25 Sep 2020 06:49:51 +0000 Authentication-Results: zsh.org; iprev=pass (mail-io1-f67.google.com) smtp.remote-ip=209.85.166.67; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-io1-f67.google.com ([209.85.166.67]:36499) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1kLhXx-000Fkd-6u; Fri, 25 Sep 2020 06:49:34 +0000 Received: by mail-io1-f67.google.com with SMTP id d190so1642503iof.3 for ; Thu, 24 Sep 2020 23:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=y+IfnNmw1BqE1LY6Cb3DUFs6UpK8wCR2/RvwzHO9eyw=; b=tfc8pv5n+FAr8a+S5WJQ4JpK/7Q+8+lv9waJtKa51N99ANYuOIu6YdOpSctzL509Cc KH3PI2sFXxdqANct5GiTCJ63I8UiIzALFbhlNrlT7Yfv5JVArtIlE/fYbOidgOFQ1xW6 LkQyxXgMYyjDYKtTfn+c7InZPFQKv+Myi+DgRsKZHuFPKv8nQXlD4xESxEtHtrrx2AHQ qSEzwBwgvguGsZHB3/ed/AsnBr7pLuPOUxImZxKYvLjoRwJ2ijoLfasAd+pqVS6sv5qL rev4fX/Y1aEXy7Qj8kNZ4jpCPjrWSaT1bunPuQEnSQv9uwH/m1ZekoEbjUp9SlQRDmBx +eCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=y+IfnNmw1BqE1LY6Cb3DUFs6UpK8wCR2/RvwzHO9eyw=; b=ftw0kOUelXFfKgNobW6NnF1TupfHjwXyTFdw9uHLOzUm7EXXFspCcf1t16i0QxcCDK DK+frukPiOlnkEVOZ86GhhQ55yU59SOanA5oMDGP0FVUlSYG9+IFzuXpOUEmDy2q7aCs qzE9lcRWltLiUoT1SxfGCp/dT+JGTFI6hTMBvhvYMd1VamA17evLcpoiwxZA/ObgLdTP mAQOyx+KvO4RGhJXuXZJkgQ8lAryEYDS/9q5WxD5hCxLJrLK4RYAGpwwfssfByX9OLfT OSVSHvDrDmyhnbnC5kPnLUWPmGVzgjqx5Dpk6VapIwd5BpgCZ21VGVcKeLxLZH4eV/g8 jZrg== X-Gm-Message-State: AOAM532xMl+3lZ7ZPG4SRx9PL4zOH5MWQcXT/gIOVCY98FIwlrGVGvHU YBFzFv40tNrVtxn0FcuovoaYHQFM2b7EoiGS02I= X-Google-Smtp-Source: ABdhPJzdukCA3eZN/rge754VV6JI/gcgkXn7zYeZGiOxGYnP91IoI7PHwn4hChODbpBPiorHni42+hdkFJKnr6K40cA= X-Received: by 2002:a5d:97cd:: with SMTP id k13mr2167825ios.164.1601016571602; Thu, 24 Sep 2020 23:49:31 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4f:3757:0:0:0:0:0 with HTTP; Thu, 24 Sep 2020 23:49:30 -0700 (PDT) In-Reply-To: <20200925063411.GD29504@tarpaulin.shahaf.local2> References: <20200924203441.80963-1-guidocella91@gmail.com> <20200925063411.GD29504@tarpaulin.shahaf.local2> From: Mikael Magnusson Date: Fri, 25 Sep 2020 08:49:30 +0200 Message-ID: Subject: Re: [PATCH] _git-grep: Complete files when outside git repos To: Daniel Shahaf Cc: Guido Cella , zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 47399 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: On 9/25/20, Daniel Shahaf wrote: > Guido Cella wrote on Thu, Sep 24, 2020 at 22:34:41 +0200: >> --- >> Completion/Unix/Command/_git | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git >> index 05e2a23..67f06c5 100644 >> --- a/Completion/Unix/Command/_git >> +++ b/Completion/Unix/Command/_git >> @@ -1037,6 +1037,12 @@ _git-grep () { >> # don't complete treeishs. >> case $state in >> (tree-or-file) >> + # Check if we're not in a git repository. >> + if ! git rev-parse 2>/dev/null; then >> + _files && ret=3D0 >> + return ret >> + fi > > Why is this correct? When cwd isn't a repository, =C2=ABgit grep foo ./b= ar=C2=BB > just errors out: > . > % ls > iota > % git grep This iota > fatal: not a git repository (or any parent up to mount point /) > Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not > set). > zsh: exit 128 > > Does newer git behave differently? If not, shouldn't the behaviour be > conditional on --no-index having been passed? grep.fallbackToNoIndex If set to true, fall back to git grep --no-index if git grep is execute= d outside of a git repository. Defaults to false. I guess if we want to be fancy we can check for this option / command line switch, but it seems easier to just complete files in this context since git can be configured to accept them here. --=20 Mikael Magnusson