From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13618 invoked by alias); 14 Jun 2017 04:45:28 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41287 Received: (qmail 26393 invoked from network); 14 Jun 2017 04:45:28 -0000 X-Qmail-Scanner-Diagnostics: from mail-oi0-f43.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.218.43):SA:0(-1.0/5.0):. Processed in 1.561184 secs); 14 Jun 2017 04:45:28 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: mikachu@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.218.43 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=PTDSnM1FbdvIOZVoNoWFjCc7wLeFjI3lNpRP23eq/IA=; b=uh5SLXmTUCf/XlzXelU/UHdlNJAiTSYJ4Hq2pDjdTSQo9iJWjOmo4rpvVX+M+UCXcl S6s0MATK2LF+1wc3dwEVZk8+pTGc6qyeDdSBzINMOyt0WN0Cl6wmr2tb43DCv7in06as m4+z3FoeinOL5NcinguyD4hgy5myNWY9dQ9R6VNkd3BL2uiC0SnTPbZH+96HBOJrcZMw /U5sqOarIEuSeRclTHVBCG07y5SBeF5VVBlGVfMs/xAjt2ie8034JUMq3bGpr+8VnLRi 7jPQQDyQDT3EyZlCwHGeL71x3Dj3roe6SPucu5Ak0m0MSEQ8p6tCpaYB5b49W89jBGYg pHmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=PTDSnM1FbdvIOZVoNoWFjCc7wLeFjI3lNpRP23eq/IA=; b=Ip3e0/KWs3y9g5oo5u7H20AyG6V05Ah+EzEbpZWe+iI5GOz6EWNVWYjroqFgJS5GYQ 91loroDqAOAOhJwpGZ+tmF0k4gcyQtbpafKP07JBzF0POCrxzyS8g5CzBZA9CqkjA/cv ZM4NP2HQYpYDUfYVX9x837ku+OcqR49roiH4m5L5slxgwscT/+dmM/4HLlA5O2UGtE6b HuwnL06oIpIP6xrfptZzCfSvHSzDOHwiiOy7KvHQRq0t55luUv3U1xIrd28BwaYp6f30 BgKVnl8tNEaoPmuBc2DiIeGqycKBNBM6zncCm993U6fu94sVEAJUEPKzU02IgSIcT4bT jFXQ== X-Gm-Message-State: AKS2vOzpKq3o6ucsCph4rTN8vLLz7pbMhzv7thW/t2Qbpk4gP4ZRqlL9 2VKphL7p3m6RN41IjsnQ70rtLG+dXQ== X-Received: by 10.202.230.139 with SMTP id d133mr2017426oih.110.1497415521665; Tue, 13 Jun 2017 21:45:21 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <170407103320.ZM27783@torch.brasslantern.com> <2017-04-08_03.58.46@mobil.systemanalysen.net> From: Mikael Magnusson Date: Wed, 14 Jun 2017 06:45:21 +0200 Message-ID: Subject: Re: Another minor =~ glitch To: Bart Schaefer Cc: "zsh-workers@zsh.org" Content-Type: text/plain; charset="UTF-8" On Sat, Apr 8, 2017 at 7:23 AM, Bart Schaefer wrote: > On Fri, Apr 7, 2017 at 6:58 PM, Roland Eggner wrote: >> >> Regression observed since my Zsh update >> from bb6c08b51a079870 to fc1fedda954e1d10. > > Thanks, that narrows it down to this: > > diff --git a/Src/cond.c b/Src/cond.c > index 9b739f6..a638412 100644 > --- a/Src/cond.c > +++ b/Src/cond.c > @@ -139,9 +139,9 @@ evalcond(Estate state, char *fromtest) > l = 2; > } > if (name && IS_DASH(name[0])) > - errname = name; > + untokenize(errname = name); > else if (strs[0] && IS_DASH(*strs[0])) > - errname = strs[0]; > + untokenize(errname = strs[0]); > else > errname = ""; > if (name && IS_DASH(name[0]) && This patch causes segfaults for me (in the first hunk at least) because name can be a readonly string. Should we ztrdup it? -- Mikael Magnusson