From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50 invoked by alias); 1 Jun 2017 21:22:26 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41195 Received: (qmail 15380 invoked from network); 1 Jun 2017 21:22:26 -0000 X-Qmail-Scanner-Diagnostics: from mail-qt0-f178.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.216.178):SA:0(-0.2/5.0):. Processed in 1.193378 secs); 01 Jun 2017 21:22:26 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_SPAM, SPF_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: mikachu@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.216.178 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1zAQbYyDo8zgH3ifsuDipv+En5+j6JcTsScHL/gFSSE=; b=Ihi0tCuS042+rijyZR8+gd/QVHOqim0/NGOfYw2AtCyu4mi+MnG0UO5afg2YHQOJeR af5UkaIFrp2hwNwI0+lQ3Gu4jdT5TboH43W50GDP6a/bueRLfvHnyGpjYa0D+98kthmu sIqGrDfKjYsVVEhiOaQnrlHL+i2MptDfkbV63ZkQpKSnKVDLVaNsKpkpb4sLGvG2RXPq 8u/6yk3QC1CXWRDZOzXxy7zLYSTjpi/dxbqVYbzmcUCMwYWvG0ro0JQh0NfSKy03oqUF /KPVw2sW/szTK3LJZ8bkEoBUIbnp3YDgC4u5wzo+phrNhjEAO0I4n8jy0iCL/d76PtTK v6bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1zAQbYyDo8zgH3ifsuDipv+En5+j6JcTsScHL/gFSSE=; b=JZoNWizOi2AjPd9Xt1j2CWIELF1/OST0/uXRrJ14dUwqjYWtZd00czG7qYZwr8DbY3 g+ASl7CLMFmflzCoS4QflANxFp9TMhFwhmOZHQUvG6VVX7w4t7PuI0IACsGRssHnDImW Zuse/wUPaLB5/fP1rCcmOMS4YChZT76vEKNc8aqZe7UnqgOscXV7A3ad2anZV8ZehZ7o w+YOZm7X4ufUdI9OhI+VMVeeQ9LTVqpUdSJMz8ddrU6THGQ04w77kZNsodk1Ktr096f0 7/hPKrpmlVPAgMzq7CWw7Mzol4yH7DCA6tw8ADUcO589JovhmgXeF8vQRlQ44mEKsDM1 O8sA== X-Gm-Message-State: AODbwcA8D9PRguYhpfOumxCE1gFq5JjJ9j9SOj4xh1fz6oqFPQuAOSa6 DEGKpkzQ9lNN8jBdenpmlu9jydDREw== X-Received: by 10.237.39.195 with SMTP id m3mr4517372qtg.164.1496352140558; Thu, 01 Jun 2017 14:22:20 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <170530224728.ZM25709@torch.brasslantern.com> References: <170528124337.ZM9444@torch.brasslantern.com> <170530224728.ZM25709@torch.brasslantern.com> From: Mikael Magnusson Date: Thu, 1 Jun 2017 23:22:20 +0200 Message-ID: Subject: Re: mikachu/badarrays (Re: Valgrind testing, ideas) To: Bart Schaefer Cc: zsh workers Content-Type: text/plain; charset="UTF-8" On Wed, May 31, 2017 at 7:47 AM, Bart Schaefer wrote: > On May 29, 3:21pm, Mikael Magnusson wrote: > } > } Well, it never worked in the first place, that's why i put "bad" in > } the name. It's basically just a documentation of the places I found > } that would need to be updated to use a cached length value, but since > } it doesn't work I guess I didn't find all of them, or I misunderstood > } some parts of the code that I changed... > > It also appears we've run out of bits for PM_CACHELEN and PM_CHECKEN, > the 19 and 20 bit positions are are now occupied by PM_DONTIMPORT_SUID > and PM_SINGLE, though I suppose PM_KSHSTORED and PM_ZSHSTORED could do > double duty as they won't apply to arrays and functions at once. > > With respect to "it doesn't work" -- in commits f4ab07b4 and b7c2ddf6 > you say you're adding typeset -C and typeset -c to control PM_CACHELEN > and PM_CHECKLEN but looking at the diffs you only added the argument > parsing; I can't find anywhere that PM_CACHELEN or PM_CHECKLEN are ever > assigned to the parameter flags? > > I believe I've now merged params.c ... I tried forcing both of the new > flags on for non-special PM_ARRAY params in createparam(), and all tests > seem to pass except those involving the $match array, which implies one > of us did something wrong in setarrvalue() for post_assignment_length. > I think. The existing code probably does something fun like assigning these flags based on the order of flags in the TYPESET_OPTSTR define. If you don't use typeset -c/-C for anything, then none of the new code should be activated and it is indeed expected that things would work. -- Mikael Magnusson