From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-33605-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 15283 invoked by alias); 6 Nov 2014 14:12:07 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 33605
Received: (qmail 12857 invoked from network); 6 Nov 2014 14:12:06 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham
	version=3.3.2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:date:message-id:subject:from:to:content-type;
        bh=bsPWwsZn9amT9imeJHEN6yIGfT3iVhjaWP5fzAMmmZ0=;
        b=YuaD4Ag/q/d/2pXBIdLAzlUBMlSG2RNNDyFbmFD3Uih6lgmmOHtNex3IG8NaD83eIG
         Tyu+XGkjdLa/aPpnSUX9segEXG05Was+G/VH/tsMe1+kvk9a/U4Q9cJakZrSIEQIdHSa
         OYmIfBUqOTcTCrec0s/2fhVeAyS3dt+F8zmwkMsVM+Al6JOrIH9xG89WjM6xZA3CLKjj
         UOv39clWUFMNGdi848XVXIrf3ymkfVx9fiyyv+LjEmiYRFvpuD9Nrx4dndv+l7Zd7ddV
         9GK7brvpSJBXL4QttZ+jOBlPn5oYJ00NfPFB7nxtkQvh3HakuO99bvHPx6CYNNqltUno
         g1HQ==
MIME-Version: 1.0
X-Received: by 10.42.129.140 with SMTP id q12mr11207225ics.68.1415283119241;
 Thu, 06 Nov 2014 06:11:59 -0800 (PST)
Date: Thu, 6 Nov 2014 15:11:59 +0100
Message-ID: <CAHYJk3TpyqP-RvumAQbzwhd8f=TGTjfP6LATAU_VZ=+9oHp5ng@mail.gmail.com>
Subject: Effectiveness of --disable-dynamic-nss?
From: Mikael Magnusson <mikachu@gmail.com>
To: zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

Hi,

Someone was mentioning on the #zsh channel that $USERNAME was empty
when they compiled statically and I vaguely remembered glibc doesn't
support name lookup statically, which led me to look at
--disable-dynamic-nss. I noticed it seems to define USE_* stuff when
the switch is not given for some HAVE_* stuff that pertains to name
lookup. However, even in the commit where it was introduced, it
skipped many HAVE_GETPWNAM (for example), and converted others, some
even within the diff context of other defines that were changed. So my
two questions are:

Is there a reason they were left alone or does the switch not work?
If they're all meant to be disabled, why not just have it #undef the
HAVE_* defines instead of defining new things and changing every user,
and hope nobody ever introduces new HAVE_* #ifdefs?

And tangentially, is $USERNAME supposed to return anything when
compiled with this switch given? The function that handles this
parameter was switched to USE_INITGROUPS but still uses HAVE_GETPWNAM,
which is confusing to me.

-- 
Mikael Magnusson