From: Mikael Magnusson <mikachu@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: [PATCH] zle: Call zle-line-pre-redraw when popping from bufstack.
Date: Sun, 25 Sep 2016 16:00:56 +0200 [thread overview]
Message-ID: <CAHYJk3Tui5zWX5zhj=zMVpE7P0QYzMU1mZ-GciTjgVNQ=uqePw@mail.gmail.com> (raw)
In-Reply-To: <1474809905-12861-1-git-send-email-danielsh@fujitsu.shahaf.local2>
On Sun, Sep 25, 2016 at 3:25 PM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> ---
> I'd appreciate another pair of eyes; it looks correct but I'm not very
> familiar with this part of the code.
>
> Originally reported as <https://github.com/zsh-users/zsh-syntax-highlighting/issues/40>.
It's a nice looking patch, but it doesn't actually make any difference
for me. If it did, calling the syntax hilight hook from the
zle-line-init hook function should have worked too, since that hook is
called 3 lines later.
The only thing I've found that makes it work is calling redrawhook()
from inside zrefresh() but we obviously don't want to do that.
--
Mikael Magnusson
next prev parent reply other threads:[~2016-09-25 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 13:25 Daniel Shahaf
2016-09-25 14:00 ` Mikael Magnusson [this message]
2016-09-26 9:59 ` PATCH: Call the pre-redraw hook if there is text in the buffer on init Mikael Magnusson
2016-09-30 4:54 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHYJk3Tui5zWX5zhj=zMVpE7P0QYzMU1mZ-GciTjgVNQ=uqePw@mail.gmail.com' \
--to=mikachu@gmail.com \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).