From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4254 invoked by alias); 25 Sep 2016 14:06:14 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39433 Received: (qmail 5047 invoked from network); 25 Sep 2016 14:06:14 -0000 X-Qmail-Scanner-Diagnostics: from mail-qt0-f181.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.216.181):SA:0(0.0/5.0):. Processed in 0.304664 secs); 25 Sep 2016 14:06:14 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM,SPF_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: mikachu@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.216.181 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=hd/SNnE9EU5NvrVQrf1vAT2IaUzk+wJqaLFJp68z1Ys=; b=bMpDLLkcOTdXjPVCdoOcSYXv67lcU+JMCFNxjrqqbUY1SUYAF4EiX/L+oN6BX+hNmW wofHDJap7SWYb3GC1uytXIp0pOOvECYAvxvMDkSgVDby31zXj+We38v1zGAIpHSsAVAZ XOnjr8Hl3l+f7lfO2GTTjvwr9f+cQZn06IMkzUeNETm7h3Q+33lls6mS3kH0M7zCfg0M kjvbOWGFEE8+Wf6BkcVpTXdLQFlfZkGjv4rN8Y2aihljO5VySkDCI49NMBsAkulSF8Mx L4VLI0D0Nq2oK/rq1w3usZUJMEQyEGCjdOcw/TpyjJvgjlOxNwLsywt8gqS/1FR2BMsX +d6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hd/SNnE9EU5NvrVQrf1vAT2IaUzk+wJqaLFJp68z1Ys=; b=Vdhrfm9NAA3xk5qHsBF2F5dcPRUjBnYtS52ZG5IQwcpUxzfkH6uwcIdGz9NHsZ2hwV 9srRqsJxUfs3d9RjeUIujU899ljbQrANdsD2EXMCtK324mhdXdxsXtuLbuCbvgUR3e+i uJ+HyUqgl8Nuzqz9YmfLt/UIvVtNjz5J7aVcJO+o9LWexeZNr4ua+DxWjbXis20fvctt yihh52dJe3Ewm4Yr9N97KO4juH3QzEFbwxHwalvXwDL/296yBb7bL0mrsjAyYxc+trLA Uy2MsjugrWwrxv+Z4cpaUqBLW8EOY9gRBT/gmO1qRfGbSqwtC2Z/oHOhJxLa/bXV0EHY XTbw== X-Gm-Message-State: AA6/9Rm2s61FsiHHpeWfgp+Qi697cVAzqKaUOQYRtYwz495C1Cs1BEinrma+BuNxj4CBqtfmf651MxurnohuiA== X-Received: by 10.237.43.36 with SMTP id p33mr17559100qtd.143.1474812056842; Sun, 25 Sep 2016 07:00:56 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1474809905-12861-1-git-send-email-danielsh@fujitsu.shahaf.local2> References: <1474809905-12861-1-git-send-email-danielsh@fujitsu.shahaf.local2> From: Mikael Magnusson Date: Sun, 25 Sep 2016 16:00:56 +0200 Message-ID: Subject: Re: [PATCH] zle: Call zle-line-pre-redraw when popping from bufstack. To: Daniel Shahaf Cc: zsh workers Content-Type: text/plain; charset=UTF-8 On Sun, Sep 25, 2016 at 3:25 PM, Daniel Shahaf wrote: > --- > I'd appreciate another pair of eyes; it looks correct but I'm not very > familiar with this part of the code. > > Originally reported as . It's a nice looking patch, but it doesn't actually make any difference for me. If it did, calling the syntax hilight hook from the zle-line-init hook function should have worked too, since that hook is called 3 lines later. The only thing I've found that makes it work is calling redrawhook() from inside zrefresh() but we obviously don't want to do that. -- Mikael Magnusson