From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: Plug some fd leaks in bin_print
Date: Wed, 7 Jan 2015 04:15:44 +0100 [thread overview]
Message-ID: <CAHYJk3TxK3CUoV8n_Lg409j_eUkEYETREO-f4ebjLxi5cfSiTg@mail.gmail.com> (raw)
In-Reply-To: <150106172131.ZM815@torch.brasslantern.com>
On Wed, Jan 7, 2015 at 2:21 AM, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Jan 7, 1:25am, Mikael Magnusson wrote:
> } Subject: PATCH: Plug some fd leaks in bin_print
> }
> } Found by Coverity (Issue 439120).
>
> Adding a whole bunch of "goto" is really the best way to fix this?
It seemed nicer than copying that four line mess of ternary operators
to 10 different places.
--
Mikael Magnusson
next prev parent reply other threads:[~2015-01-07 3:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 0:25 Mikael Magnusson
2015-01-07 1:21 ` Bart Schaefer
2015-01-07 3:15 ` Mikael Magnusson [this message]
2015-01-07 6:35 ` Bart Schaefer
2015-01-07 7:08 ` PATCH (differently) " Bart Schaefer
2015-01-07 7:14 ` Bart Schaefer
2015-01-07 8:26 ` Mikael Magnusson
2015-01-07 17:04 ` Bart Schaefer
2015-01-07 8:04 ` Mikael Magnusson
2015-01-07 8:06 ` Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3TxK3CUoV8n_Lg409j_eUkEYETREO-f4ebjLxi5cfSiTg@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).