From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-34152-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 25073 invoked by alias); 7 Jan 2015 03:15:51 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 34152
Received: (qmail 17604 invoked from network); 7 Jan 2015 03:15:49 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham
	version=3.3.2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=5qZ/LlnYQuKyhDupJaUvCOjqj5hrJehaxErf3pm/DIA=;
        b=Fn4HCKUCri8EsfFgpi5M6y5a6Z9Hgo/R+AXWxpZHRpOCssb8xVl2lrm6uNXX07a9zb
         JQ8fMj1+PBztFHwhW7ZS53pVFsmRZpZPXOwTkeWjXRoBIT0NpSibmFKEqmR1hCFiurlr
         RWDylU3oJLxfmvEAzi+ZpAoZPAIIYdxJ3kmKSjnr/23KPc2DBDVbuN3NVk3/cv7YIYoM
         Z5QyI8A7Rbf9N2aRmoeYj0NpHMTfA8m+v4e2GQDuoSxHhBFQysMHVwIfTpHWRX9twAvT
         380lAFIQTfaj6TAdlbcaVwuciJ90pLL5sLPViMNKGr5Gs9O00Fwe7+F5pnhBkt0GWNXM
         ISqA==
MIME-Version: 1.0
X-Received: by 10.107.128.87 with SMTP id b84mr711771iod.42.1420600544569;
 Tue, 06 Jan 2015 19:15:44 -0800 (PST)
In-Reply-To: <150106172131.ZM815@torch.brasslantern.com>
References: <1420590318-17047-1-git-send-email-mikachu@gmail.com>
	<150106172131.ZM815@torch.brasslantern.com>
Date: Wed, 7 Jan 2015 04:15:44 +0100
Message-ID: <CAHYJk3TxK3CUoV8n_Lg409j_eUkEYETREO-f4ebjLxi5cfSiTg@mail.gmail.com>
Subject: Re: PATCH: Plug some fd leaks in bin_print
From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Wed, Jan 7, 2015 at 2:21 AM, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Jan 7,  1:25am, Mikael Magnusson wrote:
> } Subject: PATCH: Plug some fd leaks in bin_print
> }
> } Found by Coverity (Issue 439120).
>
> Adding a whole bunch of "goto" is really the best way to fix this?

It seemed nicer than copying that four line mess of ternary operators
to 10 different places.

-- 
Mikael Magnusson