From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_ADSP_CUSTOM_MED,
	FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham
	autolearn_force=no version=3.4.2
Received: (qmail 17024 invoked from network); 26 Apr 2020 22:58:13 -0000
Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2)
  by inbox.vuxu.org with UTF8ESMTPZ; 26 Apr 2020 22:58:13 -0000
Received: (qmail 20808 invoked by alias); 26 Apr 2020 22:58:02 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 45721
Received: (qmail 8874 invoked by uid 1010); 26 Apr 2020 22:58:02 -0000
X-Qmail-Scanner-Diagnostics: from mail-oo1-f44.google.com by f.primenet.com.au (envelope-from <amynbe@gmail.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.102.2/25793. spamassassin: 3.4.4.  
 Clear:RC:0(209.85.161.44):SA:0(-2.0/5.0):. 
 Processed in 1.450766 secs); 26 Apr 2020 22:58:02 -0000
X-Envelope-From: amynbe@gmail.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.161.44 as permitted sender)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
        bh=VK3JMwxS1Igm4i5qkVri160oSiIe03xaJvy/kOuBJIk=;
        b=b1QD+AJIyxgljLCydHpM3yMsuMajccWsgqYtMEFxdK6ZKTklflzNyVnf3f2nzcjO3H
         8JclYT/SVFZbljNKz2weW4KLtlWvGGNk9lkj96h2Ar+r+cWWun3Cx1qsueHS+XZS187X
         88peTjkgipVmUec31PSJSOD8mbz/5cH6MiGdCGUuT4XVa9bu437Q04sRuocsi4+TuEhE
         VgMkggOZj/Y/Ryhqnyrtm5u6DrYEk6t+8CrU2wfoSmw2rx9n+ppg+XNqjBM5hvb7uvK5
         FJ4Qy/hL4t8FDIXgir5fsi/fq6ZCkbo+POmjl01g/vwWql6sivgKahy9paHgLFSFrXfc
         1gQw==
X-Gm-Message-State: AGi0Pua6b30IpSKnMYQaJBgQxKpu+4TyZj7IobyPNhbcvP7bVNK+4+n4
	GFVFinzulwCb9W6UsTd/Gltsis+eo7HmupxTqpn+aS+59+Q=
X-Google-Smtp-Source: APiQypInZDZ9XwWC05p73lNUCV5aXZpiA6qvuEfP1XKnolkgiz7l02HByFixv0/jSISUbAfMlMhAadu+cqHbGlPpUHE=
X-Received: by 2002:a4a:6c2:: with SMTP id 185mr16730031ooj.3.1587941847136;
 Sun, 26 Apr 2020 15:57:27 -0700 (PDT)
MIME-Version: 1.0
From: Amyn Bennamane <amynbe@gmail.com>
Date: Sun, 26 Apr 2020 23:57:16 +0100
Message-ID: <CAJ=fZjNLqQi3oLvzf3pd9j7OVKNMS3i_759dFrNWPkOM7yYKug@mail.gmail.com>
Subject: Git-add completion should show full file paths
To: zsh-workers@zsh.org
Content-Type: text/plain; charset="UTF-8"

Hi all,

Daniel Shahaf kindly reviewed this pull request of mine:
https://github.com/zsh-users/zsh/pull/55.

The code turned out to be wrong but I'll summarise what would be nice
to have here:

If you have multiple files buried under subfolders, the current
completions only show top level folders.

Example, if you have a folder `src` containing files `bar1` and `bar2`:

```
% git add <TAB>
 -- modified file --
src
 -- untracked file --
foo  src
```

What I want is:

```
% git add <TAB>
 -- Unstaged --
foo       src/bar1  src/bar2
```

Quoting Daniel:

I see that offering `src/bar1` and `src/bar2` right off the bat can be
useful. However, I'm not sure how best to implement it. I wonder if it
would make sense to teach `_multi_parts` some sort of
`dont-try-to-be-smart-just-offer-all-matches-right-off-the-bat`
zstyle. This would solve the problem for every use of `_multi_parts`.

End quote.

Can anyone here comment on the above idea and/or suggest a way to
implement this?

Thank you in advance.


-- 
Amyn Bennamane