From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19851 invoked by alias); 4 Apr 2017 19:43:57 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 40935 Received: (qmail 14566 invoked from network); 4 Apr 2017 19:43:57 -0000 X-Qmail-Scanner-Diagnostics: from mail-wm0-f52.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(74.125.82.52):SA:0(0.8/5.0):. Processed in 1.420377 secs); 04 Apr 2017 19:43:57 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=FREEMAIL_FROM, HTML_FONT_FACE_BAD,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_SPAM,SPF_PASS,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: orlov.home@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 74.125.82.52 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=wKwMdH/APgcBSV1697DtyjmpY/Hy8F2DR0dhfgvhk2A=; b=OgFX6d9MLNDb1buAQdbqBa14Vd8EYdJ3wCP5FrpUUiizaOiOg35v41YTu58XFqr6Dk akhvyK2v7bpdBy43ReLurc2QmSoDvz8nd0YzowWS8L65Sv+K9lwutOLm+jR2dNH53z3U nClypMVOG3nxnwDh006ztTuz4VqKCria6DD9bqHJJJwPyGLoOUPPIlqetS6xrR69uKzE qiTRan+QP7UoqGFONAVkZQsTsFpt70I2XBTMrc62HEiyNyVB9D4OBrB9t47skf5RXwur JqnStgCLtZoqIrRd22JPOW3X9o+hVN6xtVZ4ACEvFvZvFppBYq9FUi58wfkweREukfhU ktcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=wKwMdH/APgcBSV1697DtyjmpY/Hy8F2DR0dhfgvhk2A=; b=Wn3djfnqoEFIJF9erjLQYb1SL3VqpyPiYztXbEYbNg64+GuO+WiwpQ6iywQz0PHB+t 8rOV5pGZtfSv8x/OdRtA84m3W+lfSSc8E2ik/DVHi3mSr+efRwfRSD4ZJmgOPwSkm1tn LowyfmLHfjV6YjCCjqwl1RQ5JKfswV5fegVyJpkAksGro3WJybHucXUXIBYp1o02Da8U grQROLxYNZwEaaKDLKdjYYJarbp+52p6oJXrgEXbzN1nCEsb23Oaqh1FqEgd86qWPPvc 8kiKne79HVDrg03gcvEMfh6nQXE3tvue/Ti8eb1t7alrHCBbw7EHpmHlZGWMvFFvDp5l leNQ== X-Gm-Message-State: AFeK/H0ulRJG6TCeQULSy6ZRP1yeLYmIaZ1D7Yi2B1hFKOgtkMgRs/E4 4XGfv8/v4qHTqGs3q2CslTeubqEDEsxUSZc= X-Received: by 10.28.227.133 with SMTP id a127mr15123315wmh.93.1491335028199; Tue, 04 Apr 2017 12:43:48 -0700 (PDT) MIME-Version: 1.0 From: Orlov Sergey Date: Tue, 4 Apr 2017 22:43:47 +0300 Message-ID: Subject: PATCH: Fix seg fault on user autocomplete under msys To: zsh-workers@zsh.org Content-Type: multipart/alternative; boundary=001a114b154498d9d7054c5c7e2b --001a114b154498d9d7054c5c7e2b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Under windows (MSYS2 or Cygwin) user names can contain local characters. For example user name "=D0=A1=D0=98=D0=A1=D0=A2=D0=95=D0=9C=D0=90" (RU_ru.u= tf-8). This leads to infinite loop in function quotestring and char array overflow. So user names need metafy. diff --git a/Src/utils.c b/Src/utils.c index b3fa3d24c..0aeb85089 100644 --- a/Src/utils.c +++ b/Src/utils.c @@ -1230,13 +1230,13 @@ adduserdir(char *s, char *t, int flags, int always) * named directory, since these are sometimes used for * special purposes. */ - nd->dir =3D ztrdup(t); + nd->di= r =3D metafy(t, -1, META_DUP); } else - nd->dir =3D ztrduppfx(t, eptr - t); + nd->dir =3D metafy(t, eptr - t , META_DUP); /* The variables PWD and OLDPWD are not to be displayed as ~PWD etc. */ if (!strcmp(s, "PWD") || !strcmp(s, "OLDPWD")) nd->node.flags |=3D ND_NOABBREV; - nameddirtab->addnode(nameddirtab, ztrdup(s), nd); + nameddirtab->addnode(nameddirtab, metafy(s, -1, META_DUP), nd); } /* Get a named directory: this function can cause a directory name * --001a114b154498d9d7054c5c7e2b--