From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id dfb59148 for ; Mon, 21 Jan 2019 21:56:56 +0000 (UTC) Received: (qmail 28931 invoked by alias); 21 Jan 2019 21:56:40 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44006 Received: (qmail 3245 invoked by uid 1010); 21 Jan 2019 21:56:40 -0000 X-Qmail-Scanner-Diagnostics: from mail-ot1-f54.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.100.2/25112. spamassassin: 3.4.2. Clear:RC:0(209.85.210.54):SA:0(-2.0/5.0):. Processed in 2.353908 secs); 21 Jan 2019 21:56:40 -0000 X-Envelope-From: sgniazdowski@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i//W4KVjtTQeLX2sXMIdfHlqjiVULthPvZM3hsn/hfg=; b=WG8g4+g9Ut9gt5cRR3KpP+E0ORqFw7wFslMgUGiguPye/1WAwd/hAMIZR45y8GRaym wZfPjk0BazOb4sxoP6AnZsDIZ6vc506S1gu+35Il6EjZwHMZ7KGv0tiYWaoVMYn9qyOA Jy26aOsw8o310DFGuSWzJz7QnVDPjzrj/lhPJ7XZ9g1oZffaUGpq2Ur5XznOLXst7v17 N0Pf4VLaCMuh/lX7t81FMXIbq4KDtwDEocNwyigCK2m09N8O4d9Ya5nuDERRY9ZJO0dH xNujdwwvyNkd2KuuIpRtMfMdl60LOXESpFQJSuFj7RDKa4VdJHfa1IVV8c2qsywPTOL9 u8xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i//W4KVjtTQeLX2sXMIdfHlqjiVULthPvZM3hsn/hfg=; b=asc0LYWciUO4G0toI21+uAr4NlWCT1wShNSE2GBw3PIUQpdeNsu81nuCvVWcexvm3J sySwY3xibSRKZE1mVXiQdITOJK6SqgWeKRa++fF7sik+tUezzTho+pmiuTuySJT9/wDD MAjzYkMjj8OFsgT2j2z+7WWc3hThoO12HoPWPLv5b/Py6bCZPFEd7QCvcKO0wu8fT9vV VXM5JNSvHxyNSjdb1H3wNFuisAIwuyCA9wC7YJ9a3V3sVcLRxHxGzMKTo+nDb2o6UMEZ Cpjm5f2wS5rj0cGFM8sYgxRc1qtzJFoUktUwaubZ/YxzSTeRwXdblI5R/era6RwkQJE3 EHMw== X-Gm-Message-State: AJcUukdaEDxeB7TGOxblWUAbiSqRIZnwTAgtedKS+J7f/sv/qi5WvVXk CChfIEetdk/uqRzJY4gPXJM0WbvbbsgrUXyNP24= X-Google-Smtp-Source: ALg8bN4Qk1NalVCMTVdGcQzhSonRBfXmG62KmNKR0feYZxTxotWzmBeATJrJ7d9dPndrpXpI1U0Gkbo11MKt2uvIPYQ= X-Received: by 2002:a9d:3b62:: with SMTP id z89mr22051502otb.134.1548107795009; Mon, 21 Jan 2019 13:56:35 -0800 (PST) MIME-Version: 1.0 References: <20190121125412.GE18595@sym.noone.org> <1548080801.4661.0.camel@samsung.com> In-Reply-To: From: Sebastian Gniazdowski Date: Mon, 21 Jan 2019 22:56:23 +0100 Message-ID: Subject: Re: ETA for zsh 5.7? (was: Test release: 5.6.2-test-3) To: Mikael Magnusson Cc: Peter Stephenson , "zsh-workers@zsh.org" Content-Type: multipart/mixed; boundary="000000000000323c46057ffeef78" --000000000000323c46057ffeef78 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 21 Jan 2019 at 20:32, Mikael Magnusson wrote: > With the commit applied, > % print -P %F{10}hello|cat -v > ^[[38;5;8;5;10mhello Following debugs shows that: 1. For color > 7, a termcap-route was being used, ignoring the fg_start_cod= e 2. For color <=3D 7, the same termap-route was being used ignoring the fg_start_code. 3. The fg_start_code-route is used only for colors <=3D 7 in some other circumstances (I'm occuring this normally for an region_highlight--&-colors<=3D7-utilizing code.) http://sprunge.us/GcRDpx (also attached as debug.txt) So basically, Mikachu has following setting: zle_highlight=3D( fg_start_code:$'\e[38;5;' ) It's always using termcap for color >=3D 8,, because of this line ~1983 in prompt.c:: if (!def && (colour > 7 || use_termcap)) { But also, the `use_termcap' is apparently always being set if colur > 7. But the new code, NEVER IGNORES fg_start_code if it's different from the default =C2=AB\e[=C2=BB. So the code starts to finally use the fg_start= _code and problems appear. The problems come from the fact that: the are additional fields needed in zle_highlight, to make it fully usable. With the new code it IS usable as it is basically USED after all when set, so e.g. a debugging code (the X04 tests) can use the zle_highlight mechanism reliably. > Blindly appending 8;5; to my custom start code seems extremely > broken and I have no idea under what circumstances it would ever be > correct to do so. In fact it directly contradicts the documentation: > > fg_start_code (\e[3) > The start of the escape sequence for the foreground colour. This > is followed by an ASCII digit representing the colour. > > 8;5; is clearly not an ASCII digit. Ok, but the documentation also misses the fact that in the OLD code, for col > 7 termcap is used anyway, and also the same for col <=3D 7, if the color is invoked in `print -P %F{5}' and possibly other situations (but not always, region_highlight utilizing the first 8 colors does use fg_start_code also in the old code). -- Sebastian Gniazdowski News: https://twitter.com/ZdharmaI IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin Blog: http://zdharma.org --000000000000323c46057ffeef78 Content-Type: text/plain; charset="US-ASCII"; name="debug.txt" Content-Disposition: attachment; filename="debug.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jr6vcols0 CkRvaW5nOiBwcmludCAtUCAlRnsxMH1oZWxsbyB8IGNhdCAtdgoKVGhlIGRlYnVnIGxvZ3MgKGNv ZGUgYXQgdGhlIGJvdHRvbSk6CgpZZXMsIHVzaW5nIHRlcm1jYXAsIGNvbG9yOjEwIC8gdGNjb2xv cnM6MjU2IC8gdXNlX3Rlcm1jYXA6MjY4NDM1NDU2ClllcywgdXNpbmcgdGVybWNhcCwgY29sb3I6 MTAgLyB0Y2NvbG9yczoyNTYgLyB1c2VfdGVybWNhcDoyNjg0MzU0NTYKTk9ULCB1c2luZyB0ZXJt Y2FwLCA3IC8gMjU2IC8gMApBcHBlbmRlZCBbXltbMzg7NTtdIHRvIHRoZSBjb2xzZXFfYnVmW15b WzM4OzU7XQpOT1QsIHVzaW5nIHRlcm1jYXAsIDAgLyAyNTYgLyAwCkFwcGVuZGVkIFteW1szODs1 O10gdG8gdGhlIGNvbHNlcV9idWZbXltbMzg7NTtdClllcywgdXNpbmcgdGVybWNhcCwgNjMgLyAy NTYgLyAyNjg0MzU0NTYKTk9ULCB1c2luZyB0ZXJtY2FwLCAwIC8gMjU2IC8gMApBcHBlbmRlZCBb XltbMzg7NTtdIHRvIHRoZSBjb2xzZXFfYnVmW15bWzM4OzU7XQpOT1QsIHVzaW5nIHRlcm1jYXAs IDcgLyAyNTYgLyAwCkFwcGVuZGVkIFteW1szODs1O10gdG8gdGhlIGNvbHNlcV9idWZbXltbMzg7 NTtdCk5PVCwgdXNpbmcgdGVybWNhcCwgMCAvIDI1NiAvIDAKQXBwZW5kZWQgW15bWzM4OzU7XSB0 byB0aGUgY29sc2VxX2J1ZlteW1szODs1O10KWWVzLCB1c2luZyB0ZXJtY2FwLCA2MyAvIDI1NiAv IDI2ODQzNTQ1NgpOT1QsIHVzaW5nIHRlcm1jYXAsIDAgLyAyNTYgLyAwCkFwcGVuZGVkIFteW1sz ODs1O10gdG8gdGhlIGNvbHNlcV9idWZbXltbMzg7NTtdCgoKRG9pbmc6IHByaW50IC1QICVGezV9 aGVsbG8gfCBjYXQgLXYKClllcywgdXNpbmcgdGVybWNhcCwgNSAvIDI1NiAvIDI2ODQzNTQ1NgpZ ZXMsIHVzaW5nIHRlcm1jYXAsIDUgLyAyNTYgLyAyNjg0MzU0NTYKTk9ULCB1c2luZyB0ZXJtY2Fw LCA3IC8gMjU2IC8gMApBcHBlbmRlZCBbXltbMzg7NTtdIHRvIHRoZSBjb2xzZXFfYnVmW15bWzM4 OzU7XQpOT1QsIHVzaW5nIHRlcm1jYXAsIDAgLyAyNTYgLyAwCkFwcGVuZGVkIFteW1szODs1O10g dG8gdGhlIGNvbHNlcV9idWZbXltbMzg7NTtdClllcywgdXNpbmcgdGVybWNhcCwgNjMgLyAyNTYg LyAyNjg0MzU0NTYKTk9ULCB1c2luZyB0ZXJtY2FwLCAwIC8gMjU2IC8gMApBcHBlbmRlZCBbXltb Mzg7NTtdIHRvIHRoZSBjb2xzZXFfYnVmW15bWzM4OzU7XQpOT1QsIHVzaW5nIHRlcm1jYXAsIDcg LyAyNTYgLyAwCkFwcGVuZGVkIFteW1szODs1O10gdG8gdGhlIGNvbHNlcV9idWZbXltbMzg7NTtd Ck5PVCwgdXNpbmcgdGVybWNhcCwgMCAvIDI1NiAvIDAKQXBwZW5kZWQgW15bWzM4OzU7XSB0byB0 aGUgY29sc2VxX2J1ZlteW1szODs1O10KWWVzLCB1c2luZyB0ZXJtY2FwLCA2MyAvIDI1NiAvIDI2 ODQzNTQ1NgpOT1QsIHVzaW5nIHRlcm1jYXAsIDAgLyAyNTYgLyAwCkFwcGVuZGVkIFteW1szODs1 O10gdG8gdGhlIGNvbHNlcV9idWZbXltbMzg7NTtdCgoKCgpkaWZmIC0tZ2l0IGEvU3JjL3Byb21w dC5jIGIvU3JjL3Byb21wdC5jCmluZGV4IDk1OWVkOGUzZC4uMTk0MWI4ZWM5IDEwMDY0NAotLS0g YS9TcmMvcHJvbXB0LmMKKysrIGIvU3JjL3Byb21wdC5jCkBAIC0xOTg3LDYgKzE5ODcsMTQgQEAg c2V0X2NvbG91cl9hdHRyaWJ1dGUoaW50IGF0ciwgaW50IGZnX2JnLCBpbnQgZmxhZ3MpCiAJICov CiAJaWYgKHRjY2FuKHRjKSAmJiAodGNjb2xvdXJzIDwgMCB8fCBjb2xvdXIgPCB0Y2NvbG91cnMp KQogCXsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgRklMRSAqZiA9IGZvcGVuKCIvdG1wL3Jl cGx5IiwgImErIik7CisgICAgICAgICAgICBpZiAoIGYgKSB7CisgICAgICAgICAgICAgICAgZnBy aW50ZihmLCAiWWVzLCB1c2luZyB0ZXJtY2FwLCBjb2xvcjolZCAvIHRjY29sb3VyczolZCAvIHVz ZV90ZXJtY2FwOiVkXG4iLCBjb2xvdXIsIHRjY29sb3VycywgdXNlX3Rlcm1jYXApOworICAgICAg ICAgICAgICAgIGZmbHVzaChmKTsKKyAgICAgICAgICAgICAgICBmY2xvc2UoZik7CisgICAgICAg ICAgICB9CisKIAkgICAgaWYgKGlzX3Byb21wdCkKIAkgICAgewogCQlpZiAoIWJ2LT5kb250Y291 bnQpIHsKQEAgLTIwMTAsNiArMjAxOCwxMyBAQCBzZXRfY29sb3VyX2F0dHJpYnV0ZShpbnQgYXRy LCBpbnQgZmdfYmcsIGludCBmbGFncykKIAkgKi8KIAlpZiAoY29sb3VyID4gNykKIAkgICAgcmV0 dXJuOworICAgIH0gZWxzZSB7CisgICAgICAgIEZJTEUgKmYgPSBmb3BlbigiL3RtcC9yZXBseSIs ICJhKyIpOworICAgICAgICBpZiAoIGYgKSB7CisgICAgICAgICAgICBmcHJpbnRmKGYsICJOT1Qs IHVzaW5nIHRlcm1jYXAsICVkIC8gJWQgLyAlZFxuIiwgY29sb3VyLCB0Y2NvbG91cnMsIHVzZV90 ZXJtY2FwKTsKKyAgICAgICAgICAgIGZmbHVzaChmKTsKKyAgICAgICAgICAgIGZjbG9zZShmKTsK KyAgICAgICAgfQogICAgIH0KIAogICAgIGlmICgoZG9fZnJlZSA9IChjb2xzZXFfYnVmID09IE5V TEwpKSkgewpAQCAtMjAxOSw2ICsyMDM0LDExIEBAIHNldF9jb2xvdXJfYXR0cmlidXRlKGludCBh dHIsIGludCBmZ19iZywgaW50IGZsYWdzKQogCiAgICAgc3RyY3B5KGNvbHNlcV9idWYsIGZnX2Jn X3NlcXVlbmNlc1tmZ19iZ10uc3RhcnQpOwogCisgICAgRklMRSAqZiA9IGZvcGVuKCIvdG1wL3Jl cGx5IiwgImErIik7CisgICAgZnByaW50ZihmLCAiQXBwZW5kZWQgWyVzXSB0byB0aGUgY29sc2Vx X2J1Zlslc11cbiIsIGZnX2JnX3NlcXVlbmNlc1tmZ19iZ10uc3RhcnQsIGNvbHNlcV9idWYpOwor ICAgIGZmbHVzaChmKTsKKyAgICBmY2xvc2UoZik7CisKICAgICBwdHIgPSBjb2xzZXFfYnVmICsg c3RybGVuKGNvbHNlcV9idWYpOwogICAgIGlmIChkZWYpIHsKIAlzdHJjcHkocHRyLCBmZ19iZ19z ZXF1ZW5jZXNbZmdfYmddLmRlZik7CgoKCg== --000000000000323c46057ffeef78--