From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 243e70dc for ; Mon, 15 Jul 2019 20:24:49 +0000 (UTC) Received: (qmail 15805 invoked by alias); 15 Jul 2019 20:24:43 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44531 Received: (qmail 16882 invoked by uid 1010); 15 Jul 2019 20:24:43 -0000 X-Qmail-Scanner-Diagnostics: from mail-ua1-f41.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25510. spamassassin: 3.4.2. Clear:RC:0(209.85.222.41):SA:0(-2.0/5.0):. Processed in 3.559204 secs); 15 Jul 2019 20:24:43 -0000 X-Envelope-From: sgniazdowski@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.222.41 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VtS+YjqIvzLV4VfBdJmZNn6ydVGlvQLvx5MnDPoVW3o=; b=Etwn+IueoiHZaTfGaMMHjQ7P6ixVJNjIKmusfSh+dSHkMexlRzwAHOnU37fB3hwZ2P L59RPhUcQo/sYaO5iPEAxOs1W/TVrAKFz5eEQiPoqfZLXXaHjmvPBD9n0kBpqxxNWxKd ZCbwcacoonk7RU9ZaoX0eqJKXsY6smGhFrtp/aaewkitD+yms/xMnwhasqbe3F7+JqAw 0yMeFu0Lp5+cFgoVqWDjHUBTCAMJOCVxQToAJSgGBO4LjMHSW/HY9Eu3MDsY9MMB8p+d 2Fs5XVr8f1RyMeqy3WraivnKy6uUXtzGlUhODMKNb8CyvYciIjnFTKzVi7s9XZzfFoNz KohQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VtS+YjqIvzLV4VfBdJmZNn6ydVGlvQLvx5MnDPoVW3o=; b=rywMOJxLGl/2iW8x5nHhug/t+HOd+olGDR+bO788NjLMqbBE/Skm0aruRmAChf7+fG Va+KCLKbDZwRna5Igldn/vf1WPeRQ9RpJSpFeQcVNww9fjBnJ9XCPF4bR366V7JoZaLY LXsIvwo9m9M5xX97dbJ8pZ2mpSfk2aC0Yckq8wc91ZIo9eoAxIL1XoFZqo7srz6fW7u+ gm61vR5xJRJRFJHhSBYNrH9JqPBMEckr6zVwM20fumOGjgGLZkoCYBIEYH+gacvVzzo1 uphpmMUa1i31EVufBkqLPJhKohu7R3y+x5iPrkSV2Rt51WVlWa1laONKdqmib4QR6kTG mPKQ== X-Gm-Message-State: APjAAAVZqOZrqz+SbSh8dSgRPUig33DWOM8/q/0GgfdYGnu2F0hcTIf2 TcoTzBX713G0KYV57ucmSVyXnbACgK20nZO3mTw= X-Google-Smtp-Source: APXvYqyqBPMOLrVsgX7mmPEG5KhqcbST4Y4q1Eml+7F1kchUxp5EnVo2C62sYnVacLX5cimnAG8BrE+rKS6v4I3AnP4= X-Received: by 2002:ab0:734f:: with SMTP id k15mr16699734uap.28.1563222246782; Mon, 15 Jul 2019 13:24:06 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Sebastian Gniazdowski Date: Mon, 15 Jul 2019 22:23:55 +0200 Message-ID: Subject: Re: PATCH: function copy To: Peter Stephenson Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" On Mon, 15 Jul 2019 at 22:01, Peter Stephenson wrote: > + if (OPT_ISSET(ops,'c')) { > + Shfunc newsh; > + if (!*argv || !argv[1] || argv[2]) { > + zwarnnam(name, "-c: requires two arguments"); > + return 1; > + } I'm probably wrong, as the tests should caught that up, but should the "argv[2]" in the line: > + if (!*argv || !argv[1] || argv[2]) { actually say "!argv[2]"? Hmm.. There's probably a shift-like operation in bin_functions, which makes the check argv[2] be actually for an third argument? -- Sebastian Gniazdowski News: https://twitter.com/ZdharmaI IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin Blog: http://zdharma.org