zsh-workers
 help / color / mirror / code / Atom feed
From: Sebastian Gniazdowski <sgniazdowski@gmail.com>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [BUG] queueing_enabled grows infinitely when in .recursive-edit
Date: Mon, 3 Oct 2016 13:55:31 +0200	[thread overview]
Message-ID: <CAKc7PVA_djOpSy41pkgqDxhyThyzCawByujFX4TqQ6rintRJGw@mail.gmail.com> (raw)
In-Reply-To: <20161003111840.3e5081f0@pwslap01u.europe.root.pri>

Thanks for the patch I've devoted much time to this. I've tested the
patch and it works. Noted one thing. Initial calc_timeout() in
raw_getbyte() can return with ZTM_NONE while there are scheduled
functions, often after Ctrl-C in .recursive-edit. Added debug prints:

            } else if (diff > 0) {
                exp100ths = diff * 100;
                if (tmoutp->tp != ZTM_KEY ||
                    exp100ths < tmoutp->exp100ths) {
                    tmoutp->exp100ths = exp100ths;
                    tmoutp->tp = ZTM_FUNC;
                } else {
                    // MY DEBUG
                    _F = fopen("/tmp/recursive.txt", "a+");
                    fprintf( _F, "-- calc_timeout ZTM_FUNC condition not meet"
                     " tmoutp->tp[%d], exp100ths[%d] < tmoutp->exp100ths[%d]\n",
                     tmoutp->tp, exp100ths, tmoutp->exp100ths);
                    fclose(_F);
                }
            } else {
                _F = fopen("/tmp/recursive.txt", "a+");
                fprintf( _F, "-- calc_timeout diff[%d] > 0 condition
not meet\n", diff);
                fclose(_F);
            }

And obtain following logs:

raw_getbyte() - queueing_enabled (0)
-- calc_timeout do_keytmout[0], keytimeout[40]
-- calc_timeout timedfns != NULL
-- calc_timeout diff[0] > 0 condition not meet
-- ^^^ INIT calc_timeout tmout.tp(0) ZTM_NONE(0) ZTM_KEY(1) / BEGIN
RAW_GETBYTE() zle_main.c

It looks like calc_timeout handles diff < 0 and diff > 0 but not diff
== 0? in the "INIT" log "tmout.tp(0)" is the value (0 == ZTM_NONE)
returned from ^^^ up calc_timeout(), and it's not ZTM_FUNC like it
rather should be (timedfns != NULL).

Best regards,
Sebastian Gniazdowski


  reply	other threads:[~2016-10-03 11:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-02 19:00 Sebastian Gniazdowski
2016-10-02 19:02 ` Sebastian Gniazdowski
2016-10-02 23:21 ` Bart Schaefer
2016-10-03 10:00   ` Sebastian Gniazdowski
2016-10-03 10:18   ` Peter Stephenson
2016-10-03 11:55     ` Sebastian Gniazdowski [this message]
2016-10-03 15:49       ` Bart Schaefer
2016-10-03 16:43         ` Sebastian Gniazdowski
2016-10-03 18:11           ` Bart Schaefer
2016-10-05  5:56         ` Sebastian Gniazdowski
2016-10-05  6:03           ` Sebastian Gniazdowski
2016-10-03 15:20     ` Bart Schaefer
2016-10-03 16:07       ` Bart Schaefer
2016-10-03 16:33   ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKc7PVA_djOpSy41pkgqDxhyThyzCawByujFX4TqQ6rintRJGw@mail.gmail.com \
    --to=sgniazdowski@gmail.com \
    --cc=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).